somandal commented on code in PR #14250:
URL: https://github.com/apache/pinot/pull/14250#discussion_r2304364075
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##########
@@ -430,18 +431,25 @@ public Map<String, TableStaleSegmentResponse>
getStaleSegmentsFromServer(
private String generateAggregateSegmentMetadataServerURL(String
tableNameWithType, List<String> columns,
String endpoint) {
tableNameWithType = URLEncoder.encode(tableNameWithType,
StandardCharsets.UTF_8);
- String paramsStr = generateColumnsParam(columns);
+ String paramsStr = generateParam(columns, "columns");
return String.format("%s/tables/%s/metadata?%s", endpoint,
tableNameWithType, paramsStr);
}
- private String generateSegmentMetadataServerURL(String tableNameWithType,
String segmentName, List<String> columns,
- String endpoint) {
+ public String generateSegmentMetadataServerURL(String tableNameWithType,
String segmentName,
+ @Nullable List<String> columns, String endpoint) {
tableNameWithType = URLEncoder.encode(tableNameWithType,
StandardCharsets.UTF_8);
segmentName = URLEncoder.encode(segmentName, StandardCharsets.UTF_8);
- String paramsStr = generateColumnsParam(columns);
+ String paramsStr = generateParam(columns, "columns");
return String.format("%s/tables/%s/segments/%s/metadata?%s", endpoint,
tableNameWithType, segmentName, paramsStr);
}
+ public String generateTableMetadataServerURL(String tableNameWithType,
@Nullable List<String> columns,
+ @Nullable List<String> segmentsToInclude, String endpoint) {
+ tableNameWithType = URLEncoder.encode(tableNameWithType,
StandardCharsets.UTF_8);
+ String paramsStr = generateParam(columns, "columns") +
generateParam(segmentsToInclude, "segments");
Review Comment:
nit: "columns" is used in a couple of places, can you add constants for
"columns" and "segments" instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
