gortiz commented on PR #16670: URL: https://github.com/apache/pinot/pull/16670#issuecomment-3219711263
> This changes the behavior (null being converted to ""). We shouldn't put null into the string dictionary, and the proper fix should be finding why null is accidentally put into the dictionary I know, but that is more complex and there could be several cases where that happens. Specifically in this case we have a UDF that returns nulls. As proven by the UDF test framework, there are tons of UDFs like that. We need a larger analysis to fix all these cases (ideally supporting an actual typesystem during execution). I've pushed a new test that verifies this case using jsonextractscalar, which is where we found the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
