This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 283b5f720e2 Fix broker request id generator to avoid generating same
id (#16661)
283b5f720e2 is described below
commit 283b5f720e2aff61d7fd1dd60ee713c4b04745cb
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Fri Aug 22 11:06:10 2025 -0700
Fix broker request id generator to avoid generating same id (#16661)
---
.../broker/broker/helix/BaseBrokerStarter.java | 23 +++++++++++-------
.../requesthandler/BaseBrokerRequestHandler.java | 5 ++--
.../BaseSingleStageBrokerRequestHandler.java | 8 ++++---
.../requesthandler/BrokerRequestIdGenerator.java | 28 +++++++++-------------
.../requesthandler/GrpcBrokerRequestHandler.java | 6 +++--
.../MultiStageBrokerRequestHandler.java | 9 +++----
.../SingleConnectionBrokerRequestHandler.java | 11 +++++----
.../requesthandler/TimeSeriesRequestHandler.java | 6 +++--
.../BaseSingleStageBrokerRequestHandlerTest.java | 2 +-
.../LiteralOnlyBrokerRequestTest.java | 15 +++++++-----
10 files changed, 62 insertions(+), 51 deletions(-)
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
index 67d366959d3..3d8a42563ac 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
@@ -48,6 +48,7 @@ import
org.apache.pinot.broker.queryquota.HelixExternalViewBasedQueryQuotaManage
import
org.apache.pinot.broker.requesthandler.BaseSingleStageBrokerRequestHandler;
import org.apache.pinot.broker.requesthandler.BrokerRequestHandler;
import org.apache.pinot.broker.requesthandler.BrokerRequestHandlerDelegate;
+import org.apache.pinot.broker.requesthandler.BrokerRequestIdGenerator;
import org.apache.pinot.broker.requesthandler.GrpcBrokerRequestHandler;
import org.apache.pinot.broker.requesthandler.MultiStageBrokerRequestHandler;
import org.apache.pinot.broker.requesthandler.MultiStageQueryThrottler;
@@ -361,12 +362,14 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
// Create Broker request handler.
String brokerId = _brokerConf.getProperty(Broker.CONFIG_OF_BROKER_ID,
getDefaultBrokerId());
+ BrokerRequestIdGenerator requestIdGenerator = new
BrokerRequestIdGenerator();
String brokerRequestHandlerType =
_brokerConf.getProperty(Broker.BROKER_REQUEST_HANDLER_TYPE,
Broker.DEFAULT_BROKER_REQUEST_HANDLER_TYPE);
BaseSingleStageBrokerRequestHandler singleStageBrokerRequestHandler;
if
(brokerRequestHandlerType.equalsIgnoreCase(Broker.GRPC_BROKER_REQUEST_HANDLER_TYPE))
{
- singleStageBrokerRequestHandler = new
GrpcBrokerRequestHandler(_brokerConf, brokerId, _routingManager,
- _accessControlFactory, _queryQuotaManager, tableCache,
_failureDetector, _resourceUsageAccountant);
+ singleStageBrokerRequestHandler =
+ new GrpcBrokerRequestHandler(_brokerConf, brokerId,
requestIdGenerator, _routingManager,
+ _accessControlFactory, _queryQuotaManager, tableCache,
_failureDetector, _resourceUsageAccountant);
} else {
// Default request handler type, i.e. netty
NettyConfig nettyDefaults = NettyConfig.extractNettyConfig(_brokerConf,
Broker.BROKER_NETTY_PREFIX);
@@ -376,9 +379,9 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
tlsDefaults = TlsUtils.extractTlsConfig(_brokerConf,
Broker.BROKER_TLS_PREFIX);
}
singleStageBrokerRequestHandler =
- new SingleConnectionBrokerRequestHandler(_brokerConf, brokerId,
_routingManager, _accessControlFactory,
- _queryQuotaManager, tableCache, nettyDefaults, tlsDefaults,
_serverRoutingStatsManager,
- _failureDetector, _resourceUsageAccountant);
+ new SingleConnectionBrokerRequestHandler(_brokerConf, brokerId,
requestIdGenerator, _routingManager,
+ _accessControlFactory, _queryQuotaManager, tableCache,
nettyDefaults, tlsDefaults,
+ _serverRoutingStatsManager, _failureDetector,
_resourceUsageAccountant);
}
MultiStageBrokerRequestHandler multiStageBrokerRequestHandler = null;
QueryDispatcher queryDispatcher = null;
@@ -390,14 +393,16 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
// TODO: decouple protocol and engine selection.
queryDispatcher = createQueryDispatcher(_brokerConf);
multiStageBrokerRequestHandler =
- new MultiStageBrokerRequestHandler(_brokerConf, brokerId,
_routingManager, _accessControlFactory,
- _queryQuotaManager, tableCache, _multiStageQueryThrottler,
_failureDetector, _resourceUsageAccountant);
+ new MultiStageBrokerRequestHandler(_brokerConf, brokerId,
requestIdGenerator, _routingManager,
+ _accessControlFactory, _queryQuotaManager, tableCache,
_multiStageQueryThrottler, _failureDetector,
+ _resourceUsageAccountant);
}
TimeSeriesRequestHandler timeSeriesRequestHandler = null;
if
(StringUtils.isNotBlank(_brokerConf.getProperty(PinotTimeSeriesConfiguration.getEnabledLanguagesConfigKey())))
{
Preconditions.checkNotNull(queryDispatcher, "Multistage Engine should be
enabled to use time-series engine");
- timeSeriesRequestHandler = new TimeSeriesRequestHandler(_brokerConf,
brokerId, _routingManager,
- _accessControlFactory, _queryQuotaManager, tableCache,
queryDispatcher, _resourceUsageAccountant);
+ timeSeriesRequestHandler =
+ new TimeSeriesRequestHandler(_brokerConf, brokerId,
requestIdGenerator, _routingManager,
+ _accessControlFactory, _queryQuotaManager, tableCache,
queryDispatcher, _resourceUsageAccountant);
}
LOGGER.info("Initializing PinotFSFactory");
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
index 59498218e25..0c9a2859c71 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
@@ -101,11 +101,13 @@ public abstract class BaseBrokerRequestHandler implements
BrokerRequestHandler {
*/
protected final Map<Long, String> _clientQueryIds;
- public BaseBrokerRequestHandler(PinotConfiguration config, String brokerId,
RoutingManager routingManager,
+ public BaseBrokerRequestHandler(PinotConfiguration config, String brokerId,
+ BrokerRequestIdGenerator requestIdGenerator, RoutingManager
routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
ThreadResourceUsageAccountant resourceUsageAccountant) {
_config = config;
_brokerId = brokerId;
+ _requestIdGenerator = requestIdGenerator;
_routingManager = routingManager;
_accessControlFactory = accessControlFactory;
_queryQuotaManager = queryQuotaManager;
@@ -113,7 +115,6 @@ public abstract class BaseBrokerRequestHandler implements
BrokerRequestHandler {
_brokerMetrics = BrokerMetrics.get();
_brokerQueryEventListener =
BrokerQueryEventListenerFactory.getBrokerQueryEventListener();
_trackedHeaders = BrokerQueryEventListenerFactory.getTrackedHeaders();
- _requestIdGenerator = new BrokerRequestIdGenerator(brokerId);
_brokerTimeoutMs = config.getProperty(Broker.CONFIG_OF_BROKER_TIMEOUT_MS,
Broker.DEFAULT_BROKER_TIMEOUT_MS);
_enableRowColumnLevelAuth =
config.getProperty(Broker.CONFIG_OF_BROKER_ENABLE_ROW_COLUMN_LEVEL_AUTH,
Broker.DEFAULT_BROKER_ENABLE_ROW_COLUMN_LEVEL_AUTH);
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java
index 199fbdf9d76..e2e76524127 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java
@@ -170,9 +170,11 @@ public abstract class BaseSingleStageBrokerRequestHandler
extends BaseBrokerRequ
protected LogicalTableRouteProvider _logicalTableRouteProvider;
public BaseSingleStageBrokerRequestHandler(PinotConfiguration config, String
brokerId,
- RoutingManager routingManager, AccessControlFactory accessControlFactory,
- QueryQuotaManager queryQuotaManager, TableCache tableCache,
ThreadResourceUsageAccountant accountant) {
- super(config, brokerId, routingManager, accessControlFactory,
queryQuotaManager, tableCache, accountant);
+ BrokerRequestIdGenerator requestIdGenerator, RoutingManager
routingManager,
+ AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
+ ThreadResourceUsageAccountant accountant) {
+ super(config, brokerId, requestIdGenerator, routingManager,
accessControlFactory, queryQuotaManager, tableCache,
+ accountant);
_disableGroovy = _config.getProperty(Broker.DISABLE_GROOVY,
Broker.DEFAULT_DISABLE_GROOVY);
_useApproximateFunction =
_config.getProperty(Broker.USE_APPROXIMATE_FUNCTION, false);
_defaultHllLog2m =
_config.getProperty(CommonConstants.Helix.DEFAULT_HYPERLOGLOG_LOG2M_KEY,
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestIdGenerator.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestIdGenerator.java
index c97ee44a0af..01a6dd4a999 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestIdGenerator.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestIdGenerator.java
@@ -18,32 +18,26 @@
*/
package org.apache.pinot.broker.requesthandler;
+import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.atomic.AtomicLong;
-/**
- * An ID generator to produce a global unique identifier for each query, used
in v1/v2 engine for tracking and
- * inter-stage communication(v2 only). It's guaranteed by:
- * <ol>
- * <li>
- * Using a mask computed using the hash-code of the broker-id to ensure
two brokers don't arrive at the same
- * requestId. This mask becomes the most significant 9 digits (in base-10).
- * </li>
- * <li>
- * Using a auto-incrementing counter for the least significant 9 digits
(in base-10).
- * </li>
- * </ol>
- */
+
+/// An ID generator to produce a global unique identifier for each query, used
in single-stage/multi-stage engine for
+/// tracking and inter-stage communication (multi-stage engine only). It's
guaranteed by:
+/// - Using a random number to ensure two brokers (or restarted broker) don't
arrive at the same request ID. This random
+/// number becomes the most significant 10 digits of the request ID (in
base-10).
+/// - Using an auto-incrementing counter for the least significant 9 digits
(in base-10).
public class BrokerRequestIdGenerator {
private static final long OFFSET = 1_000_000_000L;
- private final long _mask;
+ private final long _base;
private final AtomicLong _incrementingId = new AtomicLong(0);
- public BrokerRequestIdGenerator(String brokerId) {
- _mask = ((long) (brokerId.hashCode() & Integer.MAX_VALUE)) * OFFSET;
+ public BrokerRequestIdGenerator() {
+ _base = ThreadLocalRandom.current().nextInt(Integer.MAX_VALUE) * OFFSET;
}
public long get() {
long normalized = (_incrementingId.getAndIncrement() & Long.MAX_VALUE) %
OFFSET;
- return _mask + normalized;
+ return _base + normalized;
}
}
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java
index 402dbeade84..d20079b1150 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java
@@ -63,10 +63,12 @@ public class GrpcBrokerRequestHandler extends
BaseSingleStageBrokerRequestHandle
private final FailureDetector _failureDetector;
// TODO: Support TLS
- public GrpcBrokerRequestHandler(PinotConfiguration config, String brokerId,
RoutingManager routingManager,
+ public GrpcBrokerRequestHandler(PinotConfiguration config, String brokerId,
+ BrokerRequestIdGenerator requestIdGenerator, RoutingManager
routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
FailureDetector failureDetector, ThreadResourceUsageAccountant
accountant) {
- super(config, brokerId, routingManager, accessControlFactory,
queryQuotaManager, tableCache, accountant);
+ super(config, brokerId, requestIdGenerator, routingManager,
accessControlFactory, queryQuotaManager, tableCache,
+ accountant);
_streamingReduceService = new StreamingReduceService(config);
_streamingQueryClient = new
PinotServerStreamingQueryClient(GrpcConfig.buildGrpcQueryConfig(config));
_failureDetector = failureDetector;
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
index a366fd07144..e0fed9d8138 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
@@ -132,16 +132,17 @@ public class MultiStageBrokerRequestHandler extends
BaseBrokerRequestHandler {
private final ExecutorService _queryCompileExecutor;
protected final long _extraPassiveTimeoutMs;
- public MultiStageBrokerRequestHandler(PinotConfiguration config, String
brokerId, RoutingManager routingManager,
+ public MultiStageBrokerRequestHandler(PinotConfiguration config, String
brokerId,
+ BrokerRequestIdGenerator requestIdGenerator, RoutingManager
routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
MultiStageQueryThrottler queryThrottler, FailureDetector failureDetector,
ThreadResourceUsageAccountant accountant) {
- super(config, brokerId, routingManager, accessControlFactory,
queryQuotaManager, tableCache, accountant);
+ super(config, brokerId, requestIdGenerator, routingManager,
accessControlFactory, queryQuotaManager, tableCache,
+ accountant);
String hostname =
config.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_HOSTNAME);
int port =
Integer.parseInt(config.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_PORT));
_workerManager = new WorkerManager(_brokerId, hostname, port,
_routingManager);
- TlsConfig tlsConfig = config.getProperty(
- CommonConstants.Helix.CONFIG_OF_MULTI_STAGE_ENGINE_TLS_ENABLED,
+ TlsConfig tlsConfig =
config.getProperty(CommonConstants.Helix.CONFIG_OF_MULTI_STAGE_ENGINE_TLS_ENABLED,
CommonConstants.Helix.DEFAULT_MULTI_STAGE_ENGINE_TLS_ENABLED) ?
TlsUtils.extractTlsConfig(config,
CommonConstants.Broker.BROKER_TLS_PREFIX) : null;
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
index e8eaf389445..ac95805cea8 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
@@ -70,11 +70,12 @@ public class SingleConnectionBrokerRequestHandler extends
BaseSingleStageBrokerR
private final FailureDetector _failureDetector;
public SingleConnectionBrokerRequestHandler(PinotConfiguration config,
String brokerId,
- RoutingManager routingManager, AccessControlFactory accessControlFactory,
- QueryQuotaManager queryQuotaManager, TableCache tableCache, NettyConfig
nettyConfig, TlsConfig tlsConfig,
- ServerRoutingStatsManager serverRoutingStatsManager, FailureDetector
failureDetector,
- ThreadResourceUsageAccountant accountant) {
- super(config, brokerId, routingManager, accessControlFactory,
queryQuotaManager, tableCache, accountant);
+ BrokerRequestIdGenerator requestIdGenerator, RoutingManager
routingManager,
+ AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
+ NettyConfig nettyConfig, TlsConfig tlsConfig, ServerRoutingStatsManager
serverRoutingStatsManager,
+ FailureDetector failureDetector, ThreadResourceUsageAccountant
accountant) {
+ super(config, brokerId, requestIdGenerator, routingManager,
accessControlFactory, queryQuotaManager, tableCache,
+ accountant);
_brokerReduceService = new BrokerReduceService(_config, accountant);
_queryRouter = new QueryRouter(_brokerId, _brokerMetrics, nettyConfig,
tlsConfig, serverRoutingStatsManager);
_failureDetector = failureDetector;
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java
index 0195d9f3e77..b7c93bb4c1d 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java
@@ -69,10 +69,12 @@ public class TimeSeriesRequestHandler extends
BaseBrokerRequestHandler {
private final TimeSeriesQueryEnvironment _queryEnvironment;
private final QueryDispatcher _queryDispatcher;
- public TimeSeriesRequestHandler(PinotConfiguration config, String brokerId,
BrokerRoutingManager routingManager,
+ public TimeSeriesRequestHandler(PinotConfiguration config, String brokerId,
+ BrokerRequestIdGenerator requestIdGenerator, BrokerRoutingManager
routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
QueryDispatcher queryDispatcher, ThreadResourceUsageAccountant
accountant) {
- super(config, brokerId, routingManager, accessControlFactory,
queryQuotaManager, tableCache, accountant);
+ super(config, brokerId, requestIdGenerator, routingManager,
accessControlFactory, queryQuotaManager, tableCache,
+ accountant);
_queryEnvironment = new TimeSeriesQueryEnvironment(config, routingManager,
tableCache);
_queryEnvironment.init(config);
_queryDispatcher = queryDispatcher;
diff --git
a/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandlerTest.java
b/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandlerTest.java
index 94b9b7621ec..b007a081862 100644
---
a/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandlerTest.java
+++
b/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandlerTest.java
@@ -182,7 +182,7 @@ public class BaseSingleStageBrokerRequestHandlerTest {
new
PinotConfiguration(Map.of(Broker.CONFIG_OF_BROKER_ENABLE_QUERY_CANCELLATION,
"true"));
BrokerQueryEventListenerFactory.init(config);
BaseSingleStageBrokerRequestHandler requestHandler =
- new BaseSingleStageBrokerRequestHandler(config, "testBrokerId",
routingManager,
+ new BaseSingleStageBrokerRequestHandler(config, "testBrokerId", new
BrokerRequestIdGenerator(), routingManager,
new AllowAllAccessControlFactory(), queryQuotaManager, tableCache,
new Tracing.DefaultThreadResourceUsageAccountant()) {
@Override
diff --git
a/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java
b/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java
index 9614f29c8ef..19a3bdb90ec 100644
---
a/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java
+++
b/pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java
@@ -171,8 +171,9 @@ public class LiteralOnlyBrokerRequestTest {
public void testBrokerRequestHandler()
throws Exception {
SingleConnectionBrokerRequestHandler requestHandler =
- new SingleConnectionBrokerRequestHandler(new PinotConfiguration(),
"testBrokerId", null, ACCESS_CONTROL_FACTORY,
- null, null, null, null, mock(ServerRoutingStatsManager.class),
mock(FailureDetector.class),
+ new SingleConnectionBrokerRequestHandler(new PinotConfiguration(),
"testBrokerId",
+ new BrokerRequestIdGenerator(), null, ACCESS_CONTROL_FACTORY,
null, null, null, null,
+ mock(ServerRoutingStatsManager.class), mock(FailureDetector.class),
new Tracing.DefaultThreadResourceUsageAccountant());
long randNum = RANDOM.nextLong();
@@ -196,8 +197,9 @@ public class LiteralOnlyBrokerRequestTest {
public void testBrokerRequestHandlerWithAsFunction()
throws Exception {
SingleConnectionBrokerRequestHandler requestHandler =
- new SingleConnectionBrokerRequestHandler(new PinotConfiguration(),
"testBrokerId", null, ACCESS_CONTROL_FACTORY,
- null, null, null, null, mock(ServerRoutingStatsManager.class),
mock(FailureDetector.class),
+ new SingleConnectionBrokerRequestHandler(new PinotConfiguration(),
"testBrokerId",
+ new BrokerRequestIdGenerator(), null, ACCESS_CONTROL_FACTORY,
null, null, null, null,
+ mock(ServerRoutingStatsManager.class), mock(FailureDetector.class),
new Tracing.DefaultThreadResourceUsageAccountant());
long currentTsMin = System.currentTimeMillis();
BrokerResponse brokerResponse = requestHandler.handleRequest(
@@ -351,8 +353,9 @@ public class LiteralOnlyBrokerRequestTest {
public void testExplainPlanLiteralOnly()
throws Exception {
SingleConnectionBrokerRequestHandler requestHandler =
- new SingleConnectionBrokerRequestHandler(new PinotConfiguration(),
"testBrokerId", null, ACCESS_CONTROL_FACTORY,
- null, null, null, null, mock(ServerRoutingStatsManager.class),
mock(FailureDetector.class),
+ new SingleConnectionBrokerRequestHandler(new PinotConfiguration(),
"testBrokerId",
+ new BrokerRequestIdGenerator(), null, ACCESS_CONTROL_FACTORY,
null, null, null, null,
+ mock(ServerRoutingStatsManager.class), mock(FailureDetector.class),
new Tracing.DefaultThreadResourceUsageAccountant());
// Test 1: select constant
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
