songwdfu commented on code in PR #16308:
URL: https://github.com/apache/pinot/pull/16308#discussion_r2265406952
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/GroupByTrimmingIntegrationTest.java:
##########
@@ -225,13 +225,16 @@ public void
testMSQEGroupsTrimmedAtSegmentLevelWithOrderByOnAggregateIsNotSafe()
ResultSetGroup result = conn.execute(options + query);
assertTrimFlagSet(result);
- assertEquals(toResultStr(result),
- "\"i\"[\"INT\"],\t\"j\"[\"LONG\"],\t\"EXPR$2\"[\"LONG\"]\n"
- + "77,\t377,\t4\n"
- + "66,\t566,\t4\n"
- + "39,\t339,\t4\n"
- + "96,\t396,\t4\n"
- + "25,\t25,\t4");
+ String[] lines = toResultStr(result).split("\n");
Review Comment:
This test originally hardcodes the result for an `GROUP BY ... ORDER BY
COUNT(*)` query that has many ties (many groups have `COUNT(*) == 4`), this
should be undeterministic. Changing this to assert all top results have count
of 4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
