Jackie-Jiang commented on PR #15782:
URL: https://github.com/apache/pinot/pull/15782#issuecomment-3148587144

   > Thanks for the review. Wanna clarify about the "split", the PR itself is 
right now with only interfaces for backfill. The change that "matters" in other 
perspective is to introduce the "backfill" type of topic (different naming 
method). Do you suggest making that part independent or making the new manager 
independent?
   
   This PR covers multiple topics, which makes it hard to review (reviewer can 
miss critical pieces). We can split it into 3 parts so that reviewer can focus 
on one topic at a time:
   1. Change segment name format (this is super critical, and can cause all RT 
table to fail during upgrade if not handled properly)
   2. Add auto reset support (detect lag and reset to latest offset without 
backfill)
   3. Add backfill support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to