yashmayya commented on code in PR #16431:
URL: https://github.com/apache/pinot/pull/16431#discussion_r2240407431
##########
pinot-udf-test/src/main/java/org/apache/pinot/udf/test/UdfReporter.java:
##########
@@ -74,74 +74,117 @@ public static void reportAsMarkdown(Udf udf,
UdfTestResult.ByScenario byScenario
private static void reportScenarios(Udf udf, UdfTestResult.ByScenario
byScenario, PrintWriter report,
TreeSet<UdfTestScenario> scenarios) {
- report.append("### Scenarios\n\n");
- // This is used to create a collapsed section in the markdown report
- report.append("<details>\n"
- + "\n"
- + "<summary>Click to open</summary>\n\n");
+ if (byScenario.getMap().values().stream()
+ .flatMap(bySignature -> bySignature.getMap().values().stream())
+ .noneMatch(UdfReporter::requiresScenarioForSignature)) {
+ return ;
Review Comment:
```suggestion
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
