Jackie-Jiang commented on code in PR #16423:
URL: https://github.com/apache/pinot/pull/16423#discussion_r2229805218
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java:
##########
@@ -1165,6 +1165,10 @@ public void testTableTasksCleanupWithNonActiveTasks()
sendPutRequest(DEFAULT_INSTANCE.getControllerRequestURLBuilder()
.forResumeMinionTaskQueue(MinionConstants.SegmentGenerationAndPushTask.TASK_TYPE));
+ // Explicitly delete the stopped task to ensure it's completely cleaned up
Review Comment:
This is against the purpose of this test. Deleting a table should handle
this cleanup. I believe this test failure catches a bug in the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
