raghavyadav01 commented on code in PR #16276:
URL: https://github.com/apache/pinot/pull/16276#discussion_r2216668467
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/regexp/RegexpLikeVarFunctions.java:
##########
@@ -33,8 +33,21 @@ private RegexpLikeVarFunctions() {
@ScalarFunction
public static boolean regexpLikeVar(String inputStr, String regexPatternStr)
{
- Pattern pattern = Pattern.compile(regexPatternStr, Pattern.UNICODE_CASE |
Pattern.CASE_INSENSITIVE);
- return pattern.matcher(inputStr).find();
+ return Pattern.compile(regexPatternStr,
Pattern.UNICODE_CASE).matcher(inputStr).find();
Review Comment:
Yes, this is not consistent. I will make the change to use
PatternFactory.compile to make it consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
