bziobrowski commented on code in PR #16349:
URL: https://github.com/apache/pinot/pull/16349#discussion_r2210014228
##########
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONMessageDecoder.java:
##########
@@ -67,9 +66,4 @@ public GenericRow decode(byte[] payload, GenericRow
destination) {
return null;
}
}
-
Review Comment:
If offset/length is really used, instead of copying array in the super
implementation, we could pass wrap payload in ByteArrayInputStream with offset
and length, e.g.
```java
public static JsonNode bytesToJsonNode(byte[] jsonBytes, int offset, int
length)
throws IOException {
return DEFAULT_READER.readTree(new ByteArrayInputStream(jsonBytes,
offset, length));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
