Jackie-Jiang commented on code in PR #16326:
URL: https://github.com/apache/pinot/pull/16326#discussion_r2201634163
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -418,6 +418,7 @@ public void start()
Tracing.ThreadAccountantOps.initializeThreadAccountant(
_brokerConf.subset(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX),
_instanceId,
org.apache.pinot.spi.config.instance.InstanceType.BROKER);
+ Tracing.ThreadAccountantOps.startThreadAccountant();
Review Comment:
Based on my code reading, we cannot assume broker starts taking queries
after service status check is done. Controller will start redirecting queries
to broker whenever the table's routing is built on the broker. Broker doesn't
have the same mechanism as server to prevent queries coming in, so we need to
start the thread accountant earlier.
Routing table build is usually cheap and broker startup is usually fast, so
I feel this should be okay. We can revisit this if this is causing issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
