somandal commented on code in PR #16094:
URL: https://github.com/apache/pinot/pull/16094#discussion_r2201350064
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java:
##########
@@ -94,6 +101,27 @@ public void add(String jsonString)
addFlattenedRecords(JsonUtils.flatten(jsonString, _jsonIndexConfig));
Review Comment:
I think I found a way around this, please take a look at the latest diffs -
basically if the `getSkipInvalidJson` is false, it'll throw an Exception from
`JsonUtils.flatten()`. I now catch that exception and check if
`_continueOnError` is true, in which case I return a flattened record,
otherwise throw.
Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
