ankitsultana commented on code in PR #16286:
URL: https://github.com/apache/pinot/pull/16286#discussion_r2196637675
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -131,10 +131,20 @@ public StreamingOutput handlePostSql(String
requestJsonStr, @Context HttpHeaders
@Path("sql")
@ManualAuthorization
public StreamingOutput handleGetSql(@QueryParam("sql") String sqlQuery,
@QueryParam("trace") String traceEnabled,
- @QueryParam("queryOptions") String queryOptions, @Context HttpHeaders
httpHeaders) {
+ @QueryParam("queryOptions") String queryOptions, @Context HttpHeaders
httpHeaders) {
return executeSqlQueryCatching(httpHeaders, sqlQuery, traceEnabled,
queryOptions);
}
+ @GET
+ @Path("timeseries/api/v1/query_range")
+ @ManualAuthorization
+ @ApiOperation(value = "Prometheus Compatible API for Pinot's Time Series
Engine")
+ public StreamingOutput handleTimeSeriesQueryRange(@QueryParam("language")
String language,
Review Comment:
We were hitting issues with query parameter style API in our systems due to
hitting url/header limits.
Can we just switch to a POST API which takes in a JSON request?
I think being prometheus compatible is not worth much anyways.
Alternatively: we can go with this for now and later change this API to
mimic the exact API as broker, once we add the new and final broker API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
