krishan1390 commented on code in PR #16300:
URL: https://github.com/apache/pinot/pull/16300#discussion_r2192105466


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -626,6 +626,11 @@ public String forPauseStatus(String tableName) {
     return StringUtil.join("/", _baseUrl, "tables", tableName, "pauseStatus");
   }
 
+  public String forValidDocIdsMetadata(String tableName, String 
validDocIdsType) {

Review Comment:
   pinot-spi doesn't include pinot-common so can't add ValidDocIdsType.SNAPSHOT 
here. and didn't want to use a String version of it as that makes it harder to 
find when required to change defaults. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to