ankitsultana commented on code in PR #16296:
URL: https://github.com/apache/pinot/pull/16296#discussion_r2191298542
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/opt/rules/LeafStageWorkerAssignmentRule.java:
##########
@@ -281,7 +282,9 @@ static TableScanWorkerAssignmentResult
attemptPartitionedDistribution(String tab
int keyIndex = fieldNames.indexOf(tablePartitionInfo.getPartitionColumn());
String function = tablePartitionInfo.getPartitionFunctionName();
int numSelectedServers = instanceIdToSegmentsMap.size();
- if (keyIndex == -1) {
+ if (!DistHashFunction.isSupported(function)) {
+ return null;
+ } else if (keyIndex == -1) {
Review Comment:
I actually prefer `else if` to make code compact when it's in the middle of
the block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
