Jackie-Jiang commented on code in PR #16278:
URL: https://github.com/apache/pinot/pull/16278#discussion_r2186115486
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java:
##########
@@ -97,6 +97,9 @@ public void acquire(LLCSegmentName llcSegmentName)
while (!_semaphore.tryAcquire(WAIT_INTERVAL_MS, TimeUnit.MILLISECONDS)) {
LOGGER.warn("Failed to acquire consumer semaphore for segment: {} in:
{}ms. Retrying.", segmentName,
System.currentTimeMillis() - startTimeMs);
+
_serverMetrics.addTimedTableValue(_realtimeTableDataManager.getTableName(),
Review Comment:
I'm thinking making it a gauge indicating the total wait time (i.e.
`System.currentTimeMillis() - startTimeMs`) so that it won't be averaged out.
When the lock is acquired, reset the gauge back to 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
