noob-se7en commented on code in PR #16279:
URL: https://github.com/apache/pinot/pull/16279#discussion_r2184667461
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -820,6 +823,9 @@ public void run() {
_state = State.HOLDING;
SegmentCompletionProtocol.Response response =
postSegmentConsumedMsg();
SegmentCompletionProtocol.ControllerResponseStatus status =
response.getStatus();
+ if (_shouldStop) {
+ break;
Review Comment:
Let's add a log here as why we ignored controller respones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
