rhodo commented on code in PR #16149:
URL: https://github.com/apache/pinot/pull/16149#discussion_r2176180892
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -232,15 +250,63 @@ public void setNotNull(boolean notNull) {
_notNull = notNull;
}
- public int getMaxLength() {
+ /**
+ * Returns the effective max length to be used.
+ * This method should be used in business logic instead of {@code
getMaxLength()},
+ * as it falls back to data type-specific or global defaults when the field
is unset.
+ */
+ @JsonIgnore
Review Comment:
Yep, added one in
pinot-spi/src/test/java/org/apache/pinot/spi/data/FieldSpecTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
