9aman commented on code in PR #16071:
URL: https://github.com/apache/pinot/pull/16071#discussion_r2174250885
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2572,6 +2565,36 @@ public void
repairSegmentsInErrorStateForPauselessConsumption(TableConfig tableC
}
}
+ private boolean allowRepairOfErrorSegments(boolean
repairErrorSegmentsForPartialUpsertOrDedup,
+ TableConfig tableConfig) {
+ if (repairErrorSegmentsForPartialUpsertOrDedup) {
+ // If API context has repairErrorSegmentsForPartialUpsertOrDedup=true,
allow repair.
+ return true;
+ }
+
+ boolean isPartialUpsertEnabled = (tableConfig.getUpsertConfig() != null)
&& (tableConfig.getUpsertConfig().getMode()
+ == UpsertConfig.Mode.PARTIAL);
+ if (isPartialUpsertEnabled) {
+ // If isPartialUpsert is enabled, do not allow repair.
+ return false;
+ }
Review Comment:
@noob-se7en given that this behavior can be kept common for partial upsert
and dedup, we can put this config in stream ingestion config as suggested by
@Jackie-Jiang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
