ankitsultana commented on code in PR #16105:
URL: https://github.com/apache/pinot/pull/16105#discussion_r2164824159
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -506,6 +506,13 @@ protected TableConfig getRealtimeTableConfig() {
return getRealtimeTableConfig(getTableName());
}
+ /**
+ * Returns the headers to be used for Pinot client transport.
+ */
+ protected Map<String, String> getPinotClientTransportHeaders() {
Review Comment:
nit: clearly specify what Pinot client transport means. I think it means the
JDBC Connection `PinotConnection`? You can perhaps do that link thing: `{@link
PinotConnection}`
Similar comment for connectionClientRequest and segmentUploadAuth methods.
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -728,6 +728,29 @@ public SimpleHttpResponse uploadSegment(URI uri, String
segmentName, File segmen
return uploadSegment(uri, segmentName, segmentFile, null, parameters,
HttpClient.DEFAULT_SOCKET_TIMEOUT_MS);
}
+ /**
+ * Upload segment with segment file using default settings. Include table
name and type as a request parameters.
Review Comment:
nit: I see it's borrowed from the other method above. But these are not
default settings right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
