deemoliu commented on code in PR #16113:
URL: https://github.com/apache/pinot/pull/16113#discussion_r2164695512
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java:
##########
@@ -179,20 +184,25 @@ public List<String> getInputColumns() {
@Override
public GenericRow transform(GenericRow record) {
try {
- GenericRow originalRow = _fieldsToUnnest.isEmpty() ? null :
record.copy(_fieldsToUnnest);
- flattenMap(record, new
ArrayList<>(record.getFieldToValueMap().keySet()));
- for (String field : _fieldsToUnnest) {
- unnestCollection(record, field);
- }
- Object unnestedRows = record.getValue(GenericRow.MULTIPLE_RECORDS_KEY);
- if (originalRow != null && unnestedRows instanceof Collection) {
- for (GenericRow unnestedRow : (Collection<GenericRow>) unnestedRows) {
- for (String field : _fieldsToUnnest) {
- unnestedRow.putValue(field, originalRow.getValue(field));
+ if (_retainOriginalFieldInUnnest) {
Review Comment:
Should we avoid changing the current behavior?
we can introduce this new config, and update for all our tableConfig to
apply this config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
