Copilot commented on code in PR #16168:
URL: https://github.com/apache/pinot/pull/16168#discussion_r2160100361
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -910,6 +908,10 @@ private synchronized TaskDebugInfo
getTaskDebugInfo(WorkflowContext workflowCont
TaskConfig helixTaskConfig =
jobConfig.getTaskConfig(taskIdForPartition);
if (helixTaskConfig != null) {
PinotTaskConfig pinotTaskConfig =
PinotTaskConfig.fromHelixTaskConfig(helixTaskConfig);
+ if ((tableNameWithType != null) &&
(!tableNameWithType.equals(pinotTaskConfig.getTableName()))) {
+ // Filter task configs that matches this table name
Review Comment:
Grammar: 'configs that matches' should be 'configs that match'.
```suggestion
// Filter task configs that match this table name
```
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -826,11 +826,9 @@ public synchronized Map<String, TaskDebugInfo>
getTasksDebugInfoByTable(String t
if (pinotConfigs != null) {
String tableNameConfig = pinotConfigs.get(TABLE_NAME);
if (tableNameConfig != null &&
tableNameConfig.equals(tableNameWithType)) {
- // Found a match. Add task debug info to the result
- // TODO: If a task consists of subtasks belonging to the current
table and other tables at the same time,
- // we will collect debug info of them all. We may want to filter
out debug info that does not belong
- // to the given table.
- taskDebugInfos.put(pinotTaskName,
getTaskDebugInfo(workflowContext, helixJobName, verbosity));
+ // Found a match. Add task debug info for this table to the result
Review Comment:
[nitpick] There's an extra space between 'table' and 'to' in the comment.
Remove the double space for consistency.
```suggestion
// Found a match. Add task debug info for this table to the
result
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
