matvj250 opened a new pull request, #16166: URL: https://github.com/apache/pinot/pull/16166
_General Description_ This is a revised version of this PR - https://github.com/apache/pinot/pull/15954 - which itself is a continuation of this PR - https://github.com/apache/pinot/pull/15868. The revisions come from Tianle's comments in the previous PR. We want to migrate certain API files to pinot-spi for compatibility gating. broker.api.AccessControl, server.access.AccessControl, and controller.api.access.AccessControl can all be migrated to pinot-spi by: - Migrating their necessary dependencies - ex. common.request.BrokerRequest - to pinot-spi. - Updating the pinot-spi pom with the io.netty, javax.ws.rs, javax.annotation and thrift dependencies. - Disabling the checkstyle checks for the thrift-generated files that were migrated in config/suppressions.xml. - Applying `mvn spotless:apply`. _Finer-Grain Notes_ - I moved pinot-common/src/thrift/query.thrift to pinot-spi, since all its generated files were moved to pinot-spi. I also moved split request.thrift into two same-named files (one in pinot-common and one in pinot-spi) to reflect how I had only moved some of the files generated by request.thrift to pinot-spi. - The thrift-generated files were moved to pinot-spi/.../request/, the parent thrift files were moved to pinot-spi/.../thrift/, while the other files were moved to pinot-spi/.../auth/, with specific subfolders for the migratedbroker, server, controller, and core files. This is a full list of how packages were migrated/renamed in this PR and the previous, https://github.com/apache/pinot/pull/15868: broker.api.AccessControl --> spi.auth.broker.AccessControl broker.api.RequesterIdentity --> spi.auth.broker.RequesterIdentity common.request.BrokerRequest --> spi.request.BrokerRequest common.request.DataSource --> spi.request.DataSource common.request.Expression --> spi.request.Expression common.request.ExpressionType --> spi.request.ExpressionType common.request.Function --> spi.request.Function common.request.Identifier --> spi.request.Identifier common.request.Join --> spi.request.Join common.request.JoinType --> spi.request.JoinType common.request.Literal --> spi.request.Literal common.request.PinotQuery --> spi.request.PinotQuery common.request.QuerySource --> spi.request.QuerySource controller.api.access.AccessControl --> spi.auth.controller.AccessType controller.api.access.AccessType --> spi.auth.controller.AccessType core.auth.FineGrainedAccessControl --> spi.auth.core.FineGrainedAccessControl core.auth.TargetType --> spi.auth.core.TargetType server.access.AccessControl --> spi.auth.server.AccessControl server.access.RequesterIdentity --> spi.auth.server.RequesterIdentity query.thrift (originally in pinot-common/thrift) request.thrift (split into two files, one is still in pinot-common/thrift) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
