J-HowHuang commented on code in PR #16096:
URL: https://github.com/apache/pinot/pull/16096#discussion_r2154929058
##########
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##########
@@ -174,5 +174,35 @@ export const rebalanceServerOptions:
RebalanceServerOption[] = [
"isAdvancedConfig": true,
"isStatsGatheringConfig": false,
"markWithWarningIcon": false
+ },
+ {
+ "name": "forceCommitBeforeMoved",
+ "defaultValue": false,
+ "type": "BOOL",
+ "label": "Force Commit Before Moved",
+ "description": "Do force commit on consuming segments before they are
rebalanced",
+ "isAdvancedConfig": false,
+ "isStatsGatheringConfig": false,
+ "markWithWarningIcon": false
+ },
+ {
+ "name": "forceCommitBatchSize",
+ "defaultValue": 2147483647,
+ "type": "INTEGER",
+ "label": "Force Commit Batch Size",
+ "description": "If forceCommitBeforeMoved is set, this is the batch
size for force commit operations. Controls how many segments are force
committed in each batch. (Default to Integer.MAX to disable batching)",
+ "isAdvancedConfig": true,
+ "isStatsGatheringConfig": false,
+ "markWithWarningIcon": false
+ },
+ {
+ "name": "forceCommitBatchStatusCheckTimeoutMs",
Review Comment:
Right now I expose force commit batch size and timeout to the UI, keeping
force commit check interval to the API (as other similar parameters), and
default the values to what they are in the forceCommit API. Is this good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
