somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2150710912
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/DefaultTenantRebalancer.java:
##########
@@ -184,16 +277,16 @@ private String createUniqueRebalanceJobIdentifier() {
return UUID.randomUUID().toString();
}
- private Set<String> getTenantTables(String tenantName) {
+ public Set<String> getTenantTables(String tenantName) {
Review Comment:
nit: I double checked and it does look like you can remove the `public` here
since the test is in the same package. that way unnecessary functions aren't
public. always better to err on the side of least access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
