gortiz commented on code in PR #16007:
URL: https://github.com/apache/pinot/pull/16007#discussion_r2149879499
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -200,6 +217,52 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ private static Level successfulSummarizeLevel(SqlNodeAndOptions
sqlNodeAndOptions) {
+ String key =
CommonConstants.MultiStageQueryRunner.KEY_OF_SUCCESSFUL_SUMMARIZE_LOG;
+ String defaultValue =
CommonConstants.MultiStageQueryRunner.DEFAULT_OF_SUCCESSFUL_SUMMARIZE_LOG;
+ String str = sqlNodeAndOptions.getOptions().getOrDefault(key,
defaultValue);
+ try {
+ return Level.valueOf(StringUtils.upperCase(str));
+ } catch (IllegalArgumentException e) {
+ // If the value is not a valid Level, default to DEBUG
Review Comment:
I've changed this code so we don't need to parse levels
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -200,6 +217,52 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ private static Level successfulSummarizeLevel(SqlNodeAndOptions
sqlNodeAndOptions) {
+ String key =
CommonConstants.MultiStageQueryRunner.KEY_OF_SUCCESSFUL_SUMMARIZE_LOG;
+ String defaultValue =
CommonConstants.MultiStageQueryRunner.DEFAULT_OF_SUCCESSFUL_SUMMARIZE_LOG;
+ String str = sqlNodeAndOptions.getOptions().getOrDefault(key,
defaultValue);
+ try {
+ return Level.valueOf(StringUtils.upperCase(str));
+ } catch (IllegalArgumentException e) {
+ // If the value is not a valid Level, default to DEBUG
+ return Level.DEBUG;
+ }
+ }
+
+ private void summarizeQuery(BrokerResponse brokerResponse, Level
successfulSummarizeLevel) {
+ ObjectNode stats = brokerResponse instanceof BrokerResponseNativeV2
+ ? ((BrokerResponseNativeV2) brokerResponse).getStageStats()
+ : JsonNodeFactory.instance.objectNode();
+ String successfullyStr = brokerResponse.getExceptions().isEmpty()
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
