Jackie-Jiang commented on code in PR #16099:
URL: https://github.com/apache/pinot/pull/16099#discussion_r2148850749
##########
.github/workflows/scripts/pr-tests/.pinot_tests_unit.sh:
##########
@@ -29,15 +29,20 @@ netstat -i
# - TEST_SET#1 runs install and test together so the module list must ensure
no additional modules were tested
# due to the -am flag (include dependency modules)
if [ "$RUN_TEST_SET" == "1" ]; then
- mvn test \
+ mvn test -T 16 \
+ -am \
+ -pl 'pinot-core' \
-pl 'pinot-spi' \
-pl 'pinot-segment-spi' \
-pl 'pinot-common' \
- -pl ':pinot-yammer' \
- -pl 'pinot-core' \
-pl 'pinot-query-planner' \
-pl 'pinot-query-runtime' \
-P github-actions,codecoverage,no-integration-tests || exit 1
+
+ mvn test \
+ -am \
+ -pl ':pinot-yammer' \
+ -P github-actions,codecoverage,no-integration-tests || exit 1
fi
if [ "$RUN_TEST_SET" == "2" ]; then
mvn test \
Review Comment:
Let's add some comment here stating these test must be running
single-threaded
##########
.github/workflows/scripts/pr-tests/.pinot_tests_unit.sh:
##########
@@ -29,15 +29,20 @@ netstat -i
# - TEST_SET#1 runs install and test together so the module list must ensure
no additional modules were tested
# due to the -am flag (include dependency modules)
if [ "$RUN_TEST_SET" == "1" ]; then
- mvn test \
+ mvn test -T 16 \
+ -am \
+ -pl 'pinot-core' \
Review Comment:
(minor) Keep `pinot-core` after `pinot-common` to follow the dependency chain
##########
.github/workflows/scripts/pr-tests/.pinot_tests_unit.sh:
##########
@@ -29,15 +29,20 @@ netstat -i
# - TEST_SET#1 runs install and test together so the module list must ensure
no additional modules were tested
# due to the -am flag (include dependency modules)
if [ "$RUN_TEST_SET" == "1" ]; then
- mvn test \
+ mvn test -T 16 \
+ -am \
+ -pl 'pinot-core' \
-pl 'pinot-spi' \
-pl 'pinot-segment-spi' \
-pl 'pinot-common' \
- -pl ':pinot-yammer' \
- -pl 'pinot-core' \
-pl 'pinot-query-planner' \
-pl 'pinot-query-runtime' \
-P github-actions,codecoverage,no-integration-tests || exit 1
+
+ mvn test \
+ -am \
+ -pl ':pinot-yammer' \
Review Comment:
We can move this to suite 2 to run it single-threaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
