xiangfu0 commented on code in PR #16107:
URL: https://github.com/apache/pinot/pull/16107#discussion_r2147029610
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##########
@@ -301,6 +301,17 @@ private boolean shouldDeleteInProgressLLCSegment(String
segmentName, IdealState
private List<String> getSegmentsToDeleteFromDeepstore(String
tableNameWithType, RetentionStrategy retentionStrategy,
List<SegmentZKMetadata> segmentZKMetadataList, int
untrackedSegmentsDeletionBatchSize) {
List<String> segmentsToDelete = new ArrayList<>();
+ if (TableNameBuilder.isRealtimeTableResource(tableNameWithType)) {
Review Comment:
Yes, the logic here is:
- For HYBRID table, this method will be called twice, once for OFFLINE table
and once for REALTIME table. We only process the untrackedSegments when
processing the OFFLINE table.
- For REALTIME or OFFLINE only table, this logic keep as the previous
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
