Copilot commented on code in PR #16085:
URL: https://github.com/apache/pinot/pull/16085#discussion_r2142037357
##########
pinot-controller/src/main/resources/app/pages/TenantDetails.tsx:
##########
@@ -878,6 +904,19 @@ const TenantPageDetails = ({ match }:
RouteComponentProps<Props>) => {
addLinks
showSearchBox={true}
inAccordionFormat={true}
+ additionalControls={
+ <StatusFilter
+ value={segmentStatusFilter}
+ onChange={setSegmentStatusFilter}
+ options={[
+ { label: 'All', value: 'ALL' },
+ { label: 'Bad or Updating', value: 'BAD_OR_UPDATING' },
+ { label: 'Bad', value: DISPLAY_SEGMENT_STATUS.BAD },
+ { label: 'Updating', value:
DISPLAY_SEGMENT_STATUS.UPDATING },
+ { label: 'Good', value: DISPLAY_SEGMENT_STATUS.GOOD },
+ ]}
+ />
+ }
Review Comment:
[nitpick] The StatusFilter component is instantiated twice in this file;
consider reusing the already defined segmentStatusFilterElement variable to
reduce code duplication and improve maintainability.
```suggestion
additionalControls={segmentStatusFilterElement}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
