somandal commented on code in PR #16079:
URL: https://github.com/apache/pinot/pull/16079#discussion_r2141163073
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java:
##########
@@ -147,6 +147,9 @@ public static void validate(Schema schema, boolean
isIgnoreCase) {
.equals(FieldSpec.DataType.DOUBLE)) {
validateDefaultIsNotNaN(fieldSpec);
}
+ if (!fieldSpec.isSingleValueField()) {
Review Comment:
within the if condition we also look for PK candidates, and then validate
that the configured PKs actually exist. I'm guessing those checks should only
be done for non-virtual columns, right?
Perhaps we can revisit removing this if check in a future PR so that each
check can be validated properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
