Jackie-Jiang commented on code in PR #15982:
URL: https://github.com/apache/pinot/pull/15982#discussion_r2130028156
##########
.github/workflows/pinot_tests.yml:
##########
@@ -98,8 +101,37 @@ jobs:
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- - name: Verify with binary-compatibility-check profile
- run: mvn verify -DskipTests -Pbinary-compat-check -T1C
+ # Build the PR branch's module to get a new JAR to compare
+ - name: Build SPI on PR branch
+ run: mvn clean package -T1C -pl ${{ matrix.module }} -am -DskipTests
-Dproject.build.finalName="${{ matrix.module }}"
+ - name: Checkout master into a subfolder
+ uses: actions/checkout@v4
+ with:
+ ref: master
Review Comment:
Is `master` the latest master or the base of the PR? Ideally we want to
checkout the base of the PR
##########
.github/workflows/pinot_tests.yml:
##########
@@ -81,6 +81,9 @@ jobs:
if: github.repository == 'apache/pinot'
runs-on: ubuntu-latest
name: Pinot Binary Compatibility Check
+ strategy:
+ matrix:
+ module: [ pinot-spi, pinot-segment-spi ]
Review Comment:
Consider combining them into one suite to reduce the overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
