Jackie-Jiang commented on code in PR #15783:
URL: https://github.com/apache/pinot/pull/15783#discussion_r2112950546
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1121,7 +1133,7 @@ protected SegmentBuildDescriptor
buildSegmentInternal(boolean forCommit) {
_segmentLogger.error(errorMessage, e);
_realtimeTableDataManager.addSegmentError(_segmentNameStr, new
SegmentErrorInfo(now(), errorMessage, e));
_serverMetrics.addMeteredTableValue(_clientId,
ServerMeter.SEGMENT_BUILD_FAILURE, 1);
Review Comment:
We can probably move the exception handling logic to the caller side to
reduce duplicate logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
