vrajat commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2107054526
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -84,6 +91,22 @@ public class HelixInstanceDataManager implements
InstanceDataManager {
private static final Logger LOGGER =
LoggerFactory.getLogger(HelixInstanceDataManager.class);
private final Map<String, TableDataManager> _tableDataManagerMap = new
ConcurrentHashMap<>();
+
+ // A cache for the logical table context
+ private static final String TABLE_CONFIG_PATH_PREFIX = "/CONFIGS/TABLE/";
Review Comment:
Can these constants be shared with other classes ? I remember it has been
declared in at least one more place.
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -242,6 +273,7 @@ public synchronized void shutDown() {
}
}
SegmentBuildTimeLeaseExtender.shutdownExecutor();
+ _propertyStore.unsubscribeChildChanges(LOGICAL_TABLE_PARENT_PATH,
_zkLogicalTableConfigChangeListener);
Review Comment:
Should listeners for schema and table configs also be unsubscribed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
