This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new 6f4afcc56 chore: re-enable javafmt check in CI via unified
checkCodeStyle alias (#1676)
6f4afcc56 is described below
commit 6f4afcc5688579d28dc20000cdea91440e0cc69e
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Sun Jun 14 23:00:52 2026 +0800
chore: re-enable javafmt check in CI via unified checkCodeStyle alias
(#1676)
* chore: re-enable javafmt check in CI via checkCodeStyle alias
Motivation:
Re-enable the javafmt code style check that was temporarily disabled
(issue #1401), now using the unified checkCodeStyle alias that covers
scalafmt, javafmt, and header checks.
Modification:
- Replace disabled javafmt comment with checkCodeStyle in CI workflow
- Add checkCodeStyle to the sbt command in check-build-test.yml
Result:
CI now enforces consistent code style checks (scalafmt + javafmt + headers)
using the unified checkCodeStyle alias.
Tests:
Not run - CI config change only
References:
Refs #1401
* fix: standardize build.sbt aliases and apply javafmt formatting
Motivation:
Build.sbt aliases used non-standard ordering. The pravega Java file
was not formatted with javafmt 0.12.0.
Modification:
- build.sbt: standardize checkCodeStyle and applyCodeStyle alias order
- Run javafmtAll to format PravegaTable.java
Result:
Aliases consistent with other pekko projects; Java code properly formatted.
---
.github/workflows/check-build-test.yml | 6 ++----
build.sbt | 4 ++--
.../pekko/stream/connectors/pravega/javadsl/PravegaTable.java | 1 -
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/.github/workflows/check-build-test.yml
b/.github/workflows/check-build-test.yml
index 6d355d18f..8ae0e5e4c 100644
--- a/.github/workflows/check-build-test.yml
+++ b/.github/workflows/check-build-test.yml
@@ -52,10 +52,8 @@ jobs:
- name: Cache Coursier cache
uses: coursier/cache-action@95e5b1029b6b86e7bac033ee44a0697d8a527d2d #
v6.4.7
- # Javafmt code style check disabled temporarily
- # https://github.com/apache/pekko-connectors/issues/1401
- - name: "Code style, compile tests, MiMa. Run locally with: sbt
\"+Test/compile; +mimaReportBinaryIssues\""
- run: sbt "+Test/compile; +mimaReportBinaryIssues"
+ - name: "Code style, compile tests, MiMa. Run locally with: sbt
\"checkCodeStyle; +Test/compile; +mimaReportBinaryIssues\""
+ run: sbt "checkCodeStyle; +Test/compile; +mimaReportBinaryIssues"
- name: "Integration Test Compile"
run: sbt "+aws-spi-pekko-http-int-tests/Test/compile"
diff --git a/build.sbt b/build.sbt
index 075e228b3..23942b4f0 100644
--- a/build.sbt
+++ b/build.sbt
@@ -127,8 +127,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for
https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll;
+headerCreateAll")
-addCommandAlias("checkCodeStyle", ";+headerCheckAll; scalafmtCheckAll;
scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", "+headerCreateAll; scalafmtAll; scalafmtSbt;
javafmtAll")
+addCommandAlias("checkCodeStyle", "scalafmtCheckAll; scalafmtSbtCheck;
javafmtCheckAll; +headerCheckAll")
lazy val amqp = pekkoConnectorProject("amqp", "amqp", Dependencies.Amqp)
diff --git
a/pravega/src/main/java/org/apache/pekko/stream/connectors/pravega/javadsl/PravegaTable.java
b/pravega/src/main/java/org/apache/pekko/stream/connectors/pravega/javadsl/PravegaTable.java
index 60d2969ae..432b9b010 100644
---
a/pravega/src/main/java/org/apache/pekko/stream/connectors/pravega/javadsl/PravegaTable.java
+++
b/pravega/src/main/java/org/apache/pekko/stream/connectors/pravega/javadsl/PravegaTable.java
@@ -26,7 +26,6 @@ import org.apache.pekko.stream.javadsl.Keep;
import org.apache.pekko.stream.javadsl.Sink;
import org.apache.pekko.stream.javadsl.Source;
-
import java.util.Optional;
import java.util.concurrent.CompletionStage;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
