This is an automated email from the ASF dual-hosted git repository.
pjfanning pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new a011f5d5e Replace string interpolation with placeholder-based logging
in main sources (#1653)
a011f5d5e is described below
commit a011f5d5ea78a745e66c7125181a7a5f03886343
Author: PJ Fanning <[email protected]>
AuthorDate: Mon Jun 1 11:40:47 2026 +0100
Replace string interpolation with placeholder-based logging in main sources
(#1653)
Co-authored-by: copilot-swe-agent[bot]
<[email protected]>
---
.../elasticsearch/impl/ElasticsearchSimpleFlowStage.scala | 4 ++--
.../stream/connectors/geode/impl/stage/GeodeCQueryGraphLogic.scala | 2 +-
.../pekko/stream/connectors/hbase/impl/HBaseCapabilities.scala | 2 +-
.../apache/pekko/stream/connectors/pravega/impl/PravegaFlow.scala | 2 +-
.../apache/pekko/stream/connectors/pravega/impl/PravegaSource.scala | 4 ++--
.../pekko/stream/connectors/pravega/impl/PravegaTableReadFlow.scala | 2 +-
.../stream/connectors/pravega/impl/PravegaTableWriteFlow.scala | 2 +-
.../apache/pekko/stream/connectors/solr/impl/SolrFlowStage.scala | 6 +++---
.../connectors/unixdomainsocket/impl/UnixDomainSocketImpl.scala | 2 +-
9 files changed, 13 insertions(+), 13 deletions(-)
diff --git
a/elasticsearch/src/main/scala/org/apache/pekko/stream/connectors/elasticsearch/impl/ElasticsearchSimpleFlowStage.scala
b/elasticsearch/src/main/scala/org/apache/pekko/stream/connectors/elasticsearch/impl/ElasticsearchSimpleFlowStage.scala
index ddf09c323..18e1186e1 100644
---
a/elasticsearch/src/main/scala/org/apache/pekko/stream/connectors/elasticsearch/impl/ElasticsearchSimpleFlowStage.scala
+++
b/elasticsearch/src/main/scala/org/apache/pekko/stream/connectors/elasticsearch/impl/ElasticsearchSimpleFlowStage.scala
@@ -127,7 +127,7 @@ private[elasticsearch] final class
ElasticsearchSimpleFlowStage[T, C](
inflight = false
val (resultsPassthrough, exception) = args
- log.error(s"Received error from elastic after having already processed
{} documents. Error: {}",
+ log.error("Received error from elastic after having already processed {}
documents. Error: {}",
resultsPassthrough.size,
exception)
failStage(exception)
@@ -147,7 +147,7 @@ private[elasticsearch] final class
ElasticsearchSimpleFlowStage[T, C](
if (log.isErrorEnabled) {
messageResults.filterNot(_.success).foreach { failure =>
if (failure.getError.isPresent) {
- log.error(s"Received error from elastic when attempting to index
documents. Error: {}",
+ log.error("Received error from elastic when attempting to index
documents. Error: {}",
failure.getError.get)
}
}
diff --git
a/geode/src/main/scala/org/apache/pekko/stream/connectors/geode/impl/stage/GeodeCQueryGraphLogic.scala
b/geode/src/main/scala/org/apache/pekko/stream/connectors/geode/impl/stage/GeodeCQueryGraphLogic.scala
index 96fa7558e..9dfb8764a 100644
---
a/geode/src/main/scala/org/apache/pekko/stream/connectors/geode/impl/stage/GeodeCQueryGraphLogic.scala
+++
b/geode/src/main/scala/org/apache/pekko/stream/connectors/geode/impl/stage/GeodeCQueryGraphLogic.scala
@@ -55,7 +55,7 @@ private[geode] abstract class GeodeCQueryGraphLogic[V](val
shape: SourceShape[V]
onGeodeElement(ev.getNewValue().asInstanceOf[V])
override def onError(ev: CqEvent): Unit =
- log.error(ev.getThrowable, s"$ev")
+ log.error(ev.getThrowable, "{}", ev)
override def close(): Unit = {
log.debug("closes")
diff --git
a/hbase/src/main/scala/org/apache/pekko/stream/connectors/hbase/impl/HBaseCapabilities.scala
b/hbase/src/main/scala/org/apache/pekko/stream/connectors/hbase/impl/HBaseCapabilities.scala
index 0904459b5..c19bea800 100644
---
a/hbase/src/main/scala/org/apache/pekko/stream/connectors/hbase/impl/HBaseCapabilities.scala
+++
b/hbase/src/main/scala/org/apache/pekko/stream/connectors/hbase/impl/HBaseCapabilities.scala
@@ -65,7 +65,7 @@ private[impl] trait HBaseCapabilities { this: StageLogging =>
tableDescriptor.addFamily(new HColumnDescriptor(cf))
}
admin.createTable(tableDescriptor)
- log.info(s"Table $tableName created with cfs: $columnFamilies.")
+ log.info("Table {} created with cfs: {}.", tableName, columnFamilies)
connection.getTable(tableName)
}
table
diff --git
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaFlow.scala
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaFlow.scala
index 964dc0563..d95e7872c 100644
---
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaFlow.scala
+++
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaFlow.scala
@@ -47,7 +47,7 @@ import scala.util.{ Failure, Success, Try }
private val asyncPushback: AsyncCallback[(Try[Void], A)] = getAsyncCallback {
case (Failure(exception), msg) =>
- log.error(s"Failed to send message: $msg", exception)
+ log.error(exception, "Failed to send message: {}", msg)
semaphore.release()
case (_, msg) =>
push(out, msg)
diff --git
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaSource.scala
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaSource.scala
index 715925c30..8b0afc50d 100644
---
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaSource.scala
+++
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaSource.scala
@@ -99,13 +99,13 @@ import scala.util.{ Failure, Success, Try }
log.debug("Stopping reader")
Try(reader.close()) match {
case Failure(exception) =>
- log.error(exception, s"Error while closing [{}/{}]", scope,
readerGroup.toString)
+ log.error(exception, "Error while closing [{}/{}]", scope,
readerGroup.toString)
case Success(_) =>
log.debug("Closed reader [{}/{}]", scope, readerGroup.getGroupName)
}
Try(readerGroup.close()) match {
case Failure(exception) =>
- log.error(exception, s"Error while closing reader group [{}/{}]",
scope, readerGroup.getGroupName)
+ log.error(exception, "Error while closing reader group [{}/{}]",
scope, readerGroup.getGroupName)
case Success(_) =>
log.debug("Closed reader group [{}/{}]", scope,
readerGroup.getGroupName)
}
diff --git
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableReadFlow.scala
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableReadFlow.scala
index 9d28df62a..462d0f7c2 100644
---
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableReadFlow.scala
+++
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableReadFlow.scala
@@ -54,7 +54,7 @@ import scala.util.control.NonFatal
private val asyncMessageSendCallback: AsyncCallback[Try[TableEntry]] =
getAsyncCallback { p =>
p match {
case Failure(exception) =>
- log.error(exception, s"Failed to send message {}")
+ log.error(exception, "Failed to send message {}")
case Success(kv) =>
if (kv != null)
push(out,
Some(tableSettings.valueSerializer.deserialize(kv.getValue())))
diff --git
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableWriteFlow.scala
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableWriteFlow.scala
index 8b53f7079..019746acc 100644
---
a/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableWriteFlow.scala
+++
b/pravega/src/main/scala/org/apache/pekko/stream/connectors/pravega/impl/PravegaTableWriteFlow.scala
@@ -59,7 +59,7 @@ import scala.util.control.NonFatal
private val asyncPushback: AsyncCallback[(Try[Version], KVPair)] =
getAsyncCallback { p =>
p match {
case (Failure(exception), msg) =>
- log.error(exception, s"Failed to send message {}", msg)
+ log.error(exception, "Failed to send message {}", msg)
case (_, msg) =>
push(out, msg)
}
diff --git
a/solr/src/main/scala/org/apache/pekko/stream/connectors/solr/impl/SolrFlowStage.scala
b/solr/src/main/scala/org/apache/pekko/stream/connectors/solr/impl/SolrFlowStage.scala
index 9253f2235..63e494e59 100644
---
a/solr/src/main/scala/org/apache/pekko/stream/connectors/solr/impl/SolrFlowStage.scala
+++
b/solr/src/main/scala/org/apache/pekko/stream/connectors/solr/impl/SolrFlowStage.scala
@@ -137,7 +137,7 @@ private final class SolrFlowLogic[T, C](
}
doc
}
- if (log.isDebugEnabled) log.debug(s"Update atomically $docs")
+ log.debug("Update atomically {}", docs)
client.add(collection, docs.asJava, settings.commitWithin)
}
@@ -149,14 +149,14 @@ private final class SolrFlowLogic[T, C](
.map { message =>
message.idFieldValue.get
}
- if (log.isDebugEnabled) log.debug(s"Delete the ids $docsIds")
+ log.debug("Delete the ids {}", docsIds)
client.deleteById(collection, docsIds.asJava, settings.commitWithin)
}
private def deleteEachByQuery(messages: immutable.Seq[WriteMessage[T, C]]):
UpdateResponse = {
val responses = messages.map { message =>
val query = message.query.get
- if (log.isDebugEnabled) log.debug(s"Delete by the query $query")
+ log.debug("Delete by the query {}", query)
val req = new UpdateRequest()
if (message.routingFieldValue.isDefined) req.setParam("_route_",
message.routingFieldValue.get)
req.deleteByQuery(query)
diff --git
a/unix-domain-socket/src/main/scala/org/apache/pekko/stream/connectors/unixdomainsocket/impl/UnixDomainSocketImpl.scala
b/unix-domain-socket/src/main/scala/org/apache/pekko/stream/connectors/unixdomainsocket/impl/UnixDomainSocketImpl.scala
index 569d211e6..f76048c14 100644
---
a/unix-domain-socket/src/main/scala/org/apache/pekko/stream/connectors/unixdomainsocket/impl/UnixDomainSocketImpl.scala
+++
b/unix-domain-socket/src/main/scala/org/apache/pekko/stream/connectors/unixdomainsocket/impl/UnixDomainSocketImpl.scala
@@ -281,7 +281,7 @@ private[unixdomainsocket] object UnixDomainSocketImpl {
try {
connectingChannel.register(sel, SelectionKey.OP_READ, sendReceiveContext)
val finishExpected = connectingChannel.finishConnect()
- log.debug(s"Unix domain socket connection succeeded, finish
$finishExpected")
+ log.debug("Unix domain socket connection succeeded, finish {}",
finishExpected)
require(finishExpected, "Internal error - our call to connection finish
wasn't expected.")
connectionFinished.trySuccess(Done)
} catch {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
