Author: tilman
Date: Sun Jun 14 09:23:18 2026
New Revision: 1935283
Log:
PDFBOX-5660: Sonar fix
Modified:
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
Modified:
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
==============================================================================
---
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
Sun Jun 14 09:23:15 2026 (r1935282)
+++
pdfbox/branches/3.0/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
Sun Jun 14 09:23:18 2026 (r1935283)
@@ -21,6 +21,7 @@ import static org.junit.jupiter.api.Asse
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
@@ -311,16 +312,10 @@ class TestCreateSignature
// sign PDF (will fail due to nonce and timestamp differing)
CreateSignature signing1 = new CreateSignature(keyStore,
PASSWORD.toCharArray());
signing1.setExternalSigning(externallySign);
- try
- {
- signing1.signDetached(new File(inPath), new File(outPath),
brokenMockTSA);
- fail("This should have failed");
- }
- catch (IOException e)
- {
- assertTrue(e.getCause() instanceof TSPValidationException);
- new File(outPath).delete();
- }
+ IOException ex = assertThrows(IOException.class,
+ () -> signing1.signDetached(new File(inPath), new
File(outPath), brokenMockTSA));
+ assertTrue(ex.getCause() instanceof TSPValidationException);
+ new File(outPath).delete();
mockServer.stopServer();