svn commit: r1935265 - in pdfbox/trunk: io/src/test/java/org/apache/pdfbox/io pdfbox/src/test/java/org/apache/pdfbox/cos

[tilman]

Author: tilman
Date: Sun Jun 14 07:36:51 2026
New Revision: 1935265

Log:
PDFBOX-5660: Sonar fix

Modified:
   
pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/RandomAccessReadWriteBufferTest.java
   pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/COSObjectKeyTest.java

Modified: 
pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/RandomAccessReadWriteBufferTest.java
==============================================================================
--- 
pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/RandomAccessReadWriteBufferTest.java
     Sun Jun 14 07:36:47 2026        (r1935264)
+++ 
pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/RandomAccessReadWriteBufferTest.java
     Sun Jun 14 07:36:51 2026        (r1935265)
@@ -20,7 +20,6 @@ import static org.junit.jupiter.api.Asse
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.IOException;
 
@@ -57,10 +56,6 @@ class RandomAccessReadWriteBufferTest
             assertEquals(0, randomAccessReadWrite.length());
             assertEquals(0, randomAccessReadWrite.getPosition());
         }
-        catch (Throwable throwable)
-        {
-            fail("Unexpected exception " + throwable.getMessage());
-        }
     }
 
     @Test
@@ -74,10 +69,6 @@ class RandomAccessReadWriteBufferTest
             randomAccessReadWrite.write(3);
             assertEquals(3, randomAccessReadWrite.length());
         }
-        catch (Throwable throwable)
-        {
-            fail("Unexpected exception " + throwable.getMessage());
-        }
     }
 
     @Test
@@ -91,10 +82,6 @@ class RandomAccessReadWriteBufferTest
             randomAccessReadWrite.write(new byte[] { 8, 9, 10, 11, });
             assertEquals(11, randomAccessReadWrite.length());
         }
-        catch (Throwable throwable)
-        {
-            fail("Unexpected exception " + throwable.getMessage());
-        }
     }
 
     @Test
@@ -108,10 +95,6 @@ class RandomAccessReadWriteBufferTest
             randomAccessReadWrite.write(new byte[] { 8, 9, 10, 11, });
             assertEquals(11, randomAccessReadWrite.length());
         }
-        catch (Throwable throwable)
-        {
-            fail("Unexpected exception " + throwable.getMessage());
-        }
     }
 
     @Test
@@ -130,10 +113,6 @@ class RandomAccessReadWriteBufferTest
             assertEquals(8, bytesRead[7]);
             assertEquals(11, bytesRead[10]);
         }
-        catch (Throwable throwable)
-        {
-            fail("Unexpected exception " + throwable.getMessage());
-        }
     }
 
     /**

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/COSObjectKeyTest.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/COSObjectKeyTest.java   
    Sun Jun 14 07:36:47 2026        (r1935264)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/COSObjectKeyTest.java   
    Sun Jun 14 07:36:51 2026        (r1935265)
@@ -29,7 +29,7 @@ import org.apache.pdfbox.rendering.PDFRe
 import org.junit.jupiter.api.Assertions;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import org.junit.jupiter.api.Test;
 
@@ -38,25 +38,8 @@ class COSObjectKeyTest
     @Test
     void testInputValues()
     {
-        try
-        {
-            new COSObjectKey(-1L, 0);
-            fail("An IllegalArgumentException shouzld have been thrown");
-        }
-        catch (IllegalArgumentException exception)
-        {
-
-        }
-
-        try
-        {
-            new COSObjectKey(1L, -1);
-            fail("An IllegalArgumentException shouzld have been thrown");
-        }
-        catch (IllegalArgumentException exception)
-        {
-
-        }
+        assertThrows(IllegalArgumentException.class, () -> new 
COSObjectKey(-1L, 0));
+        assertThrows(IllegalArgumentException.class, () -> new 
COSObjectKey(1L, -1));
     }
 
     @Test