Author: tilman
Date: Sat Jun 6 18:26:06 2026
New Revision: 1935079
Log:
PDFBOX-5660: use try-with-resources
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
Sat Jun 6 18:26:04 2026 (r1935078)
+++
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
Sat Jun 6 18:26:06 2026 (r1935079)
@@ -164,14 +164,12 @@ public class TestPDFToImage
public static boolean doTestFile(final File file, String inDir, String
outDir)
throws IOException
{
- PDDocument document = null;
boolean failed = false;
LOG.info("Opening: {}", file.getName());
- try
+ new FileOutputStream(new File(outDir, file.getName() +
".parseerror")).close();
+ try (PDDocument document = Loader.loadPDF(file))
{
- new FileOutputStream(new File(outDir, file.getName() +
".parseerror")).close();
- document = Loader.loadPDF(file, (String) null);
int numPages = document.getNumberOfPages();
if (numPages < 1)
{
@@ -223,13 +221,6 @@ public class TestPDFToImage
LOG.error("Error converting file {}", file.getName());
throw e;
}
- finally
- {
- if (document != null)
- {
- document.close();
- }
- }
LOG.info("Comparing: {}", file.getName());