svn commit: r1934350 - pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form

[tilman]

Author: tilman
Date: Mon May 18 11:55:28 2026
New Revision: 1934350

Log:
PDFBOX-5660: improve asserts

Modified:
   
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
   
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
      Mon May 18 11:43:48 2026        (r1934349)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
      Mon May 18 11:55:28 2026        (r1934350)
@@ -170,7 +170,7 @@ class PDChoiceTest
 
             field.setValue("DE");
 
-            assertTrue("DE".equals(field.getValue().get(0)), "The fields value 
should be set to DE");
+            assertEquals("DE", field.getValue().get(0), "The fields value 
should be set to DE");
             
             // Read the content of the normal appearance stream and check that 
it contains the display value for DE
             // which is Deutschland

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java
       Mon May 18 11:43:48 2026        (r1934349)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java
       Mon May 18 11:55:28 2026        (r1934350)
@@ -21,6 +21,7 @@ import java.io.IOException;
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -395,14 +396,14 @@ class PDFieldTest
 
         // Different fields should not be equal
         field2.setPartialName("differentField");
-        assertFalse(field1.equals(field2));
+        assertNotEquals(field1, field2);
 
         // Field should equal itself
         assertEquals(field1, field1);
 
         // Field should not equal null or other types
-        assertFalse(field1.equals(null));
-        assertFalse(field1.equals("not a field"));
+        assertNotNull(field1);
+        assertNotEquals(field1,"not a field");
     }
 
     /**