Author: tilman
Date: Mon Apr 13 15:50:12 2026
New Revision: 1933028

Log:
PDFBOX-2941: simplify code / remove catching exception that isn't thrown

Modified:
   
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
   
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/RecentFiles.java

Modified: 
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
==============================================================================
--- 
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
      Mon Apr 13 15:50:08 2026        (r1933027)
+++ 
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
      Mon Apr 13 15:50:12 2026        (r1933028)
@@ -1290,23 +1290,12 @@ public class PDFDebugger extends JFrame
     
     private void exitMenuItemActionPerformed(ActionEvent ignored)
     {
-        if( document != null )
+        IOUtils.closeQuietly(document);
+        if (!currentFilePath.startsWith("http"))
         {
-            try
-            {
-                document.close();
-                if (!currentFilePath.startsWith("http"))
-                {
-                    recentFiles.addFile(currentFilePath);
-                }
-                recentFiles.close();
-            }
-            catch( IOException e )
-            {
-                // no dialogbox, don't interfere with exit wish
-                e.printStackTrace();
-            }
+            recentFiles.addFile(currentFilePath);
         }
+        recentFiles.close();
         windowPrefs.setExtendedState(getExtendedState());
         this.setExtendedState(Frame.NORMAL);
         windowPrefs.setBounds(getBounds());

Modified: 
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/RecentFiles.java
==============================================================================
--- 
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/RecentFiles.java
   Mon Apr 13 15:50:08 2026        (r1933027)
+++ 
pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/RecentFiles.java
   Mon Apr 13 15:50:12 2026        (r1933028)
@@ -17,7 +17,6 @@
 package org.apache.pdfbox.debugger.ui;
 
 import java.io.File;
-import java.io.IOException;
 import java.util.ArrayDeque;
 import java.util.ArrayList;
 import java.util.List;
@@ -117,10 +116,8 @@ public class RecentFiles
     /**
      * This method save the present recent file history in the preference. To 
get the recent file
      * history in next session this method must be called.
-     *
-     * @throws IOException if saving in preference doesn't success.
      */
-    public void close() throws IOException
+    public void close()
     {
         writeHistoryToPref(filePaths);
     }

Reply via email to