Author: tilman
Date: Wed Mar 25 09:44:19 2026
New Revision: 1932533
Log:
PDFBOX-5660: sonar fix
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
Wed Mar 25 09:44:13 2026 (r1932532)
+++
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
Wed Mar 25 09:44:19 2026 (r1932533)
@@ -63,7 +63,7 @@ class PDDefaultAppearanceStringTest
}
@Test
- void testFontResourceUnavailable() throws IOException
+ void testFontResourceUnavailable()
{
COSString sampleString = new COSString("/Helvetica 12 Tf 0.019 0.305
0.627 rg");
assertThrows(IOException.class, () -> {
@@ -72,7 +72,7 @@ class PDDefaultAppearanceStringTest
}
@Test
- void testWrongNumberOfColorArguments() throws IOException
+ void testWrongNumberOfColorArguments()
{
COSString sampleString = new COSString("/Helvetica 12 Tf 0.305 0.627
rg");
assertThrows(IOException.class, () -> {
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
Wed Mar 25 09:44:13 2026 (r1932532)
+++
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java
Wed Mar 25 09:44:19 2026 (r1932533)
@@ -106,11 +106,8 @@ public class TestPDFToImage
* @return If the images are different, the function returns a diff image.
If the images are
* identical, the function returns null. If the size is different, a black
border on the bottom
* at the right is created.
- *
- * @throws IOException
*/
private static BufferedImage diffImages(BufferedImage bim1, BufferedImage
bim2)
- throws IOException
{
int minWidth = Math.min(bim1.getWidth(), bim2.getWidth());
int minHeight = Math.min(bim1.getHeight(), bim2.getHeight());
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
Wed Mar 25 09:44:13 2026 (r1932532)
+++
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
Wed Mar 25 09:44:19 2026 (r1932533)
@@ -128,11 +128,9 @@ class TestTextStripper
/**
* Test class initialization.
- *
- * @throws IOException If there is an error initializing the test.
*/
@BeforeAll
- static void init() throws IOException
+ static void init()
{
stripper = new PDFTextStripper();
stripper.setLineSeparator("\n");
Modified:
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
==============================================================================
---
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
Wed Mar 25 09:44:13 2026 (r1932532)
+++
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
Wed Mar 25 09:44:19 2026 (r1932533)
@@ -238,8 +238,7 @@ class TestImageIOUtils
checkBufferedImageSize(filename, image, newImage);
}
- private void checkBufferedImageSize(String filename,
- BufferedImage image, BufferedImage newImage) throws IOException
+ private void checkBufferedImageSize(String filename, BufferedImage image,
BufferedImage newImage)
{
assertEquals(image.getHeight(), newImage.getHeight(), "File '" +
filename + "' has different height after read");
assertEquals(image.getWidth(), newImage.getWidth(), "File '" +
filename + "' has different width after read");
@@ -376,7 +375,7 @@ class TestImageIOUtils
// BMP format explained here:
//
http://www.javaworld.com/article/2077561/learn-java/java-tip-60--saving-bitmap-files-in-java.html
// we skip 38 bytes and then read two 4 byte-integers and reverse the
bytes
- try (DataInputStream dis = new DataInputStream(new FileInputStream(new
File(filename))))
+ try (DataInputStream dis = new DataInputStream(new
FileInputStream(filename)))
{
int skipped = dis.skipBytes(38);
assertEquals(38, skipped, "Can't skip 38 bytes in image file " +
filename);
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java
==============================================================================
---
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java
Wed Mar 25 09:44:13 2026 (r1932532)
+++
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java
Wed Mar 25 09:44:19 2026 (r1932533)
@@ -75,14 +75,12 @@ class PDFAIdentificationOthersTest
}
@Test
- void testBadPDFAConformanceId() throws BadFieldValueException
+ void testBadPDFAConformanceId()
{
XMPMetadata metadata = XMPMetadata.createXMPMetadata();
PDFAIdentificationSchema pdfaid =
metadata.createAndAddPDFAIdentificationSchema();
String conformance = "kiohiohiohiohio";
- assertThrows(BadFieldValueException.class, () -> {
- pdfaid.setConformance(conformance);
- });
+ assertThrows(BadFieldValueException.class, () ->
pdfaid.setConformance(conformance));
}
@Test
@@ -91,9 +89,7 @@ class PDFAIdentificationOthersTest
XMPMetadata metadata = XMPMetadata.createXMPMetadata();
PDFAIdentificationSchema pdfaid =
metadata.createAndAddPDFAIdentificationSchema();
pdfaid.setPartValueWithString("1");
- assertThrows(IllegalArgumentException.class, () -> {
- pdfaid.setPartValueWithString("ojoj");
- });
+ assertThrows(IllegalArgumentException.class, () ->
pdfaid.setPartValueWithString("ojoj"));
}
}
