Author: tilman
Date: Mon Mar 23 10:12:53 2026
New Revision: 1932475
Log:
PDFBOX-6178, PDFBOX-4076: improve compareTo, by Maruan Sahyoun
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java
Mon Mar 23 08:30:22 2026 (r1932474)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java
Mon Mar 23 10:12:53 2026 (r1932475)
@@ -808,7 +808,16 @@ public final class COSName extends COSBa
{
return 0;
}
- return getName().compareTo(other.getName()); // maybe poor
implementation compared to 3.0?
+ int len = Math.min(nameBytes.length, other.nameBytes.length);
+ for (int i = 0; i < len; i++)
+ {
+ int diff = (nameBytes[i] & 0xFF) - (other.nameBytes[i] & 0xFF);
+ if (diff != 0)
+ {
+ return diff;
+ }
+ }
+ return nameBytes.length - other.nameBytes.length;
}
/**
