This is an automated email from the ASF dual-hosted git repository.
uwe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-cpp.git
The following commit(s) were added to refs/heads/master by this push:
new 1ea4be8 PARQUET-1315: ColumnChunkMetaData.has_dictionary_page()
should return…
1ea4be8 is described below
commit 1ea4be88ef8ad8afbbd037abfc3eafadc4b085a5
Author: Deepak Majeti <[email protected]>
AuthorDate: Thu May 31 12:38:41 2018 +0200
PARQUET-1315: ColumnChunkMetaData.has_dictionary_page() should return…
… bool, not int64_t
Author: Deepak Majeti <[email protected]>
Closes #469 from majetideepak/PARQUET-1315 and squashes the following
commits:
dac446e [Deepak Majeti] PARQUET-1315:
ColumnChunkMetaData.has_dictionary_page() should return bool, not int64_t
---
src/parquet/metadata.cc | 4 ++--
src/parquet/metadata.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/parquet/metadata.cc b/src/parquet/metadata.cc
index fc420b0..ee91b39 100644
--- a/src/parquet/metadata.cc
+++ b/src/parquet/metadata.cc
@@ -141,7 +141,7 @@ class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
const std::vector<Encoding::type>& encodings() const { return encodings_; }
- inline int64_t has_dictionary_page() const {
+ inline bool has_dictionary_page() const {
return column_->meta_data.__isset.dictionary_page_offset;
}
@@ -206,7 +206,7 @@ std::shared_ptr<RowGroupStatistics>
ColumnChunkMetaData::statistics() const {
bool ColumnChunkMetaData::is_stats_set() const { return impl_->is_stats_set();
}
-int64_t ColumnChunkMetaData::has_dictionary_page() const {
+bool ColumnChunkMetaData::has_dictionary_page() const {
return impl_->has_dictionary_page();
}
diff --git a/src/parquet/metadata.h b/src/parquet/metadata.h
index 3ba57ac..84c1470 100644
--- a/src/parquet/metadata.h
+++ b/src/parquet/metadata.h
@@ -108,7 +108,7 @@ class PARQUET_EXPORT ColumnChunkMetaData {
std::shared_ptr<RowGroupStatistics> statistics() const;
Compression::type compression() const;
const std::vector<Encoding::type>& encodings() const;
- int64_t has_dictionary_page() const;
+ bool has_dictionary_page() const;
int64_t dictionary_page_offset() const;
int64_t data_page_offset() const;
int64_t index_page_offset() const;
--
To stop receiving notification emails like this one, please contact
[email protected].
