MrlixiangWE commented on PR #169: URL: https://github.com/apache/otava/pull/169#issuecomment-5409628733
Done, and rebased onto a1ef00d. `_validate_append` now ensures computation rather than testing truthiness, which drops its `RuntimeError` branch — with lazy properties there's no reachable "not computed" state left. The stable-series test then surfaced a second bug: `append()` raises `KeyError` for a metric with no change points. It reproduces on master with one changing and one stable metric, so it predates this PR. I added membership checks in `append()` rather than touching `select_metrics`, since #173 asserts that `KeyError`. Happy to split it out. 231 non-container tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
