This is an automated email from the ASF dual-hosted git repository. Gerrrr pushed a commit to branch cli-defaults in repository https://gitbox.apache.org/repos/asf/otava-playground.git
commit 253acf4dc79db6dc16d095688f5bf6184e89fa19 Author: Alex Sorokoumov <[email protected]> AuthorDate: Sat May 30 18:28:16 2026 -0700 Make defaults consistent with the CLI --- src/otava_test_data/web/main.py | 20 ++++++++++---------- src/otava_test_data/web/templates/index.html | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/otava_test_data/web/main.py b/src/otava_test_data/web/main.py index 9771d2b..49b4b29 100644 --- a/src/otava_test_data/web/main.py +++ b/src/otava_test_data/web/main.py @@ -1187,8 +1187,8 @@ DETECTION_METRICS_TUTORIAL = { def run_otava_analysis( data: np.ndarray, - window_len: int = 30, - max_pvalue: float = 0.05, + window_len: int = 50, + max_pvalue: float = 0.001, min_magnitude: float = 0.0, ) -> dict[str, Any]: """ @@ -1389,8 +1389,8 @@ def timeseries_to_dict( params = otava_params or {} otava_result = run_otava_analysis( ts.data, - window_len=params.get("window_len", 30), - max_pvalue=params.get("max_pvalue", 0.05), + window_len=params.get("window_len", 50), + max_pvalue=params.get("max_pvalue", 0.001), min_magnitude=params.get("min_magnitude", 0.0), ) result["otava"] = otava_result @@ -1457,8 +1457,8 @@ async def generate_data( length: int = Query(default=200, ge=10, le=2000), seed: int = Query(default=42), run_otava: bool = Query(default=False, description="Run Otava analysis"), - window_len: int = Query(default=99999, ge=5, le=100000, description="Otava window length"), - max_pvalue: float = Query(default=0.01, ge=0.0, le=1.0, description="Otava max p-value"), + window_len: int = Query(default=50, ge=5, le=100000, description="Otava window length"), + max_pvalue: float = Query(default=0.001, ge=0.0, le=1.0, description="Otava max p-value"), tolerance: int = Query(default=5, ge=0, le=50, description="Accuracy tolerance"), # Dynamic params will be passed as query parameters request: Request = None, @@ -1510,8 +1510,8 @@ async def analyze_with_otava( generator_name: str, length: int = Query(default=200, ge=10, le=2000), seed: int = Query(default=42), - window_len: int = Query(default=30, ge=5, le=100, description="Otava window length"), - max_pvalue: float = Query(default=0.00001, ge=0.0, le=1.0, description="Otava max p-value"), + window_len: int = Query(default=50, ge=5, le=100, description="Otava window length"), + max_pvalue: float = Query(default=0.001, ge=0.0, le=1.0, description="Otava max p-value"), min_magnitude: float = Query(default=0.0, ge=0, description="Minimum change magnitude"), tolerance: int = Query(default=5, ge=0, le=50, description="Accuracy tolerance"), request: Request = None, @@ -1616,8 +1616,8 @@ class DetectRequest(BaseModel): @app.post("/api/detect") async def detect_change_points( request: DetectRequest, - window_len: int = Query(default=99999, ge=5, le=100000, description="Otava window length"), - max_pvalue: float = Query(default=0.01, ge=0.0, le=1.0, description="Otava max p-value"), + window_len: int = Query(default=50, ge=5, le=100000, description="Otava window length"), + max_pvalue: float = Query(default=0.001, ge=0.0, le=1.0, description="Otava max p-value"), min_magnitude: float = Query(default=0.0, ge=0, description="Minimum change magnitude"), ): """Run Otava change point detection on arbitrary data.""" diff --git a/src/otava_test_data/web/templates/index.html b/src/otava_test_data/web/templates/index.html index 7649ad0..936e96d 100644 --- a/src/otava_test_data/web/templates/index.html +++ b/src/otava_test_data/web/templates/index.html @@ -126,12 +126,12 @@ <div class="panel-fields"> <div class="control-group"> <label for="window-len-input" class="param-label">Window Length</label> - <input type="number" id="window-len-input" value="99999" min="5" max="100000" step="5"> + <input type="number" id="window-len-input" value="50" min="5" max="100000" step="5"> </div> <div class="control-group"> <div class="input-with-help"> <label for="max-pvalue-input" class="param-label">Max P-Value</label> - <input type="number" id="max-pvalue-input" value="0.01" step="0.01"> + <input type="number" id="max-pvalue-input" value="0.001" step="0.001"> <button type="button" class="param-help-btn" data-tooltip="Significance threshold for detecting changes. Lower values mean stricter detection (fewer false positives but may miss subtle changes). 0.05 is standard; use 0.00001 for very high confidence.">?</button> </div> </div>
