dave2wave commented on code in PR #159: URL: https://github.com/apache/otava/pull/159#discussion_r3275108391
########## docs/RELEASE.md: ########## @@ -25,9 +25,14 @@ ## Introduction The Otava community treats releases with great importance. They are a public face of the project and most users interact with the project only through the releases. Releases are signed off by the entire Otava community in a public vote. + Each release is executed by a Release Manager, who is selected/proposed by the Otava PMC members. This document describes the process that the Release Manager follows to perform a release. Any changes to this process should be discussed and adopted on the [[email protected]](mailto:[email protected]) mailing list. -Please remember, that the act of publishing software has both legal and policy significance. This guide complements the foundation-wide [Product Release Policy](https://www.apache.org/dev/release.html) and [Release Distribution Policy](https://www.apache.org/dev/release-distribution). +Please remember, that the act of publishing software has both legal and policy significance. This guide complements the foundation-wide + +* [Product Release Policy](https://www.apache.org/dev/release.html), +* [Release Distribution Policy](https://www.apache.org/dev/release-distribution),and Review Comment: The url you give redirects to https://infra.apache.org/release-distribution.html which is best to use. ########## docs/RELEASE.md: ########## @@ -241,8 +326,10 @@ Hello everyone, Please review and vote for the releasing Apache Otava (incubating) $RELEASE_VERSION-$RELEASE_CANDIDATE. -Changelog for this release candidate <>. -The official Apache source release has been deployed to https://dist.apache.org/repos/dist/dev/incubator/otava/$RELEASE_VERSION-incubating-$RELEASE_CANDIDATE/. +Release notes for this release candidate +https://github.com/apache/otava/blob/$RELEASE_VERSION-incubating-$RELEASE_CANDIDATE/docs/release-notes/$RELEASE_VERSION-incubating + +The official ASF source release has been deployed to https://dist.apache.org/repos/dist/dev/incubator/otava/$RELEASE_VERSION-incubating-$RELEASE_CANDIDATE/. Review Comment: No, it's https://dist.apache.org/repos/dist/release/incubator/otava/$RELEASE_VERSION-incubating-$RELEASE_CANDIDATE/. If this is an external list then `https://dlcdn.apache.org/incubator/otava/` for the artifacts and `https://download.apache.org/incubator/otava/` for the signatures and checksums. For archived release links - `https://archive.apache.org/dist/incubator/otava/` Please remove old releases from https://dist.apache.org/repos/dist/dev/incubator/otava/ to help reduce the Terrabyte footprint of SVN Dist. ########## docs/RELEASE.md: ########## @@ -90,8 +123,12 @@ Here, the key ID is the 8-digit hex string in the pub line: 845E6689. Now, add your Apache GPG key to the Otava's KEYS file in the [release](https://dist.apache.org/repos/dist/release/incubator/otava/KEYS) repository at [dist.apache.org](https://dist.apache.org/repos/dist/). Follow the instructions listed at the top of these files. (Note: Only PMC members have write access to the release repository. If you end up getting 403 errors ask on the mailing list for assistance.) PMC members can refer to the following scripts to add your Apache GPG key to the KEYS in the release repository. ```bash -svn co https://dist.apache.org/repos/dist/release/incubator/otava otava-dist-release-repo -cd otava-dist-release-repo +# Checkout both the dev and release repositories up front +svn co https://dist.apache.org/repos/dist/dev/incubator/otava $OTAVA_SVN_DEV +svn co https://dist.apache.org/repos/dist/release/incubator/otava $OTAVA_SVN_REL + +# For GPG key we always use the dist/release repo: +cd $OTAVA_SVN_REL (gpg --list-sigs <YOUR_KEY_ID> && gpg --armor --export <YOUR_KEY_ID>) >> KEYS svn ci -m "[otava] Add <YOUR_NAME>'s public key" ``` Review Comment: Do not remove keys that have been used to sign releases even if those releases have been archived and the key is expired. ########## docs/RELEASE.md: ########## @@ -220,12 +289,28 @@ sha512sum --check apache_otava-$RELEASE_VERSION-py3-none-any.whl.sha512 ### Publish Release Candidate ```bash -cp -r release ../otava-dist-release-repo/$RELEASE_VERSION-incubating-$RELEASE_CANDIDATE -cd ../otava-dist-release-repo +cp -r release $OTAVA_SVN_DEV/$RELEASE_VERSION-incubating-$RELEASE_CANDIDATE +cd $OTAVA_SVN_DEV +svn update && svn status + svn add $RELEASE_VERSION-incubating-$RELEASE_CANDIDATE/ -svn ci -m "[otava] Add $RELEASE_VERSION-incubating-$RELEASE_CANDIDATE" +svn ci -m "[otava] Upload $RELEASE_VERSION-incubating-$RELEASE_CANDIDATE for review and voting" +``` + +### Publish PyPI artifacts on test.pypi.org + +In svn dev/preview directory: + +```bash +# Go to dev/preview svn directory +cd $OTAVA_SVN_DEV +cd $RELEASE_VERSION-incubating-$RELEASE_CANDIDATE/pypi +# Publish to Test PyPI +twine upload --verbose --repository testpypi apache_otava-$RELEASE_VERSION-py3-none-any.whl apache_otava-$RELEASE_VERSION.tar.gz +# Verify at https://test.pypi.org/project/apache-otava/ ``` + Review Comment: @henrikingo - I agree for PyPi. With other distribution channels there is no real test and @justinmclean has a valid concern about downstream confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
