henrikingo commented on PR #154: URL: https://github.com/apache/otava/pull/154#issuecomment-4392000285
@vishnuchalla and @StephanDollberg this intersects with both of your work, you're welcome to review. Stephan: 1. This should produce similar or identical results as the default algorithm when you set window_len=10000. Can you confirm please? 2. My proposal would be to add the min_segment_len option to this new deterministic variant, and maybe also to the orig variant, but not to the split/merge aka default variant. The rationale being that the splitting and min_segment_len to some extent are canceling each other out. Fighting against each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
