Author: damjan Date: Tue Jan 31 05:05:11 2017 New Revision: 1781019 URL: http://svn.apache.org/viewvc?rev=1781019&view=rev Log: We need to pass "-DEBUG" to the linker on Windows for debugging to work.
Patch by: me Tested by: pats Modified: openoffice/trunk/main/solenv/gbuild/LinkTarget.mk openoffice/trunk/main/solenv/gbuild/gbuild.mk openoffice/trunk/main/solenv/gbuild/platform/windows.mk Modified: openoffice/trunk/main/solenv/gbuild/LinkTarget.mk URL: http://svn.apache.org/viewvc/openoffice/trunk/main/solenv/gbuild/LinkTarget.mk?rev=1781019&r1=1781018&r2=1781019&view=diff ============================================================================== --- openoffice/trunk/main/solenv/gbuild/LinkTarget.mk (original) +++ openoffice/trunk/main/solenv/gbuild/LinkTarget.mk Tue Jan 31 05:05:11 2017 @@ -30,19 +30,6 @@ # LDFLAGS # CFLAGS from environment override debug/optimization flags -ifeq ($(gb_DEBUGLEVEL),2) -gb_DEBUGGING := TRUE -endif - -ifeq ($(ENABLE_SYMBOLS),SMALL) -gb_DEBUGGING := TRUE -else ifeq ($(ENABLE_SYMBOLS),TRUE) -gb_DEBUGGING := TRUE -endif - -ifeq ($(ENABLE_CRASHDUMP),TRUE) -gb_DEBUGGING := TRUE -endif ifeq ($(gb_DEBUGGING),TRUE) CFLAGS ?= $(gb_COMPILEROPTFLAGS) $(gb_DEBUG_CFLAGS) Modified: openoffice/trunk/main/solenv/gbuild/gbuild.mk URL: http://svn.apache.org/viewvc/openoffice/trunk/main/solenv/gbuild/gbuild.mk?rev=1781019&r1=1781018&r2=1781019&view=diff ============================================================================== --- openoffice/trunk/main/solenv/gbuild/gbuild.mk (original) +++ openoffice/trunk/main/solenv/gbuild/gbuild.mk Tue Jan 31 05:05:11 2017 @@ -92,6 +92,20 @@ gb_DEBUGLEVEL := 1 endif endif +ifeq ($(gb_DEBUGLEVEL),2) +gb_DEBUGGING := TRUE +endif + +ifeq ($(ENABLE_SYMBOLS),SMALL) +gb_DEBUGGING := TRUE +else ifeq ($(ENABLE_SYMBOLS),TRUE) +gb_DEBUGGING := TRUE +endif + +ifeq ($(ENABLE_CRASHDUMP),TRUE) +gb_DEBUGGING := TRUE +endif + ifneq ($(strip $(ENABLE_PCH)),) gb_ENABLE_PCH := $(true) else Modified: openoffice/trunk/main/solenv/gbuild/platform/windows.mk URL: http://svn.apache.org/viewvc/openoffice/trunk/main/solenv/gbuild/platform/windows.mk?rev=1781019&r1=1781018&r2=1781019&view=diff ============================================================================== --- openoffice/trunk/main/solenv/gbuild/platform/windows.mk (original) +++ openoffice/trunk/main/solenv/gbuild/platform/windows.mk Tue Jan 31 05:05:11 2017 @@ -195,15 +195,17 @@ gb_LinkTarget_LDFLAGS := \ gb_DEBUG_CFLAGS := -Zi +ifeq ($(gb_DEBUGGING),TRUE) +gb_LinkTarget_LDFLAGS += -DEBUG +endif + # this does not use CFLAGS so it is not overridable ifneq ($(ENABLE_CRASHDUMP),) -gb_LinkTarget_LDFLAGS += -DEBUG gb_CFLAGS+=-Zi gb_CXXFLAGS+=-Zi endif ifeq ($(gb_DEBUGLEVEL),2) -gb_LinkTarget_LDFLAGS += -DEBUG gb_COMPILEROPTFLAGS := else gb_COMPILEROPTFLAGS := -Ob1 -Oxs -Oy-