Author: hdu Date: Thu Jan 9 10:01:41 2014 New Revision: 1556774 URL: http://svn.apache.org/r1556774 Log: #i114728# remove the unused gb_Library_add_ldflags helper
when the alternative is between - adding an add_ldflags helper and providing extensive docs about it and all other related gbuild macros - just using the already existing set_ldflags macro then that choice is easy... Modified: openoffice/trunk/main/solenv/doc/gbuild/solenv/gbuild/types.mk openoffice/trunk/main/solenv/gbuild/LinkTarget.mk Modified: openoffice/trunk/main/solenv/doc/gbuild/solenv/gbuild/types.mk URL: http://svn.apache.org/viewvc/openoffice/trunk/main/solenv/doc/gbuild/solenv/gbuild/types.mk?rev=1556774&r1=1556773&r2=1556774&view=diff ============================================================================== --- openoffice/trunk/main/solenv/doc/gbuild/solenv/gbuild/types.mk (original) +++ openoffice/trunk/main/solenv/doc/gbuild/solenv/gbuild/types.mk Thu Jan 9 10:01:41 2014 @@ -122,8 +122,6 @@ namespace gb { namespace types void set_dll_target(Path dlltarget); /// Set additional flags for the link command. void set_ldflags(List<Path> ldflags); - /// Add additional flags for the link command. - void add_ldflags(List<Path> ldflags); }; /// A target that delivers headers of some kind. class DeliversHeaders Modified: openoffice/trunk/main/solenv/gbuild/LinkTarget.mk URL: http://svn.apache.org/viewvc/openoffice/trunk/main/solenv/gbuild/LinkTarget.mk?rev=1556774&r1=1556773&r2=1556774&view=diff ============================================================================== --- openoffice/trunk/main/solenv/gbuild/LinkTarget.mk (original) +++ openoffice/trunk/main/solenv/gbuild/LinkTarget.mk Thu Jan 9 10:01:41 2014 @@ -448,10 +448,6 @@ define gb_LinkTarget_set_ldflags $(call gb_LinkTarget_get_target,$(1)) : LDFLAGS := $(2) endef -define gb_LinkTarget_add_ldflags -$(call gb_LinkTarget_get_target,$(1)) : LDFLAGS:=$$(LDFLAGS) $(2) -endef - define gb_LinkTarget_add_linked_libs ifneq (,$$(filter-out $(gb_Library_KNOWNLIBS),$(2))) $$(eval $$(call gb_Output_info,currently known libraries are: $(sort $(gb_Library_KNOWNLIBS)),ALL))