(ofbiz-framework) branch trunk updated: Remove deprecated LookupField#getTargetParameterList()

[mridulpathak]

This is an automated email from the ASF dual-hosted git repository.

mridulpathak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 30d4fa03f9 Remove deprecated LookupField#getTargetParameterList()
30d4fa03f9 is described below

commit 30d4fa03f9965e097c7bd4227a963515906322c1
Author: Mridul Pathak <mridul...@gmail.com>
AuthorDate: Mon Oct 26 22:15:19 2026 +0530

    Remove deprecated LookupField#getTargetParameterList()
    
    The no-argument method expanded the target-parameter expression with a null 
context, treating it as a plain string. Nothing in the framework or plugins 
calls it; renderers use getTargetParameterList(Map). Its only caller was a test 
that needed @SuppressWarnings("deprecation"), which is removed with it.
---
 .../org/apache/ofbiz/widget/model/ModelFormField.java | 11 -----------
 .../apache/ofbiz/widget/model/ModelFormFieldTest.java | 19 -------------------
 2 files changed, 30 deletions(-)

diff --git 
a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
 
b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
index f6fcecb89c..0070e917d8 100644
--- 
a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
+++ 
b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
@@ -4680,17 +4680,6 @@ public final class ModelFormField {
             return targetParameter.expandString(context);
         }
 
-        /**
-         * @deprecated Target Parameter is potentially a 
FlexibleStringExpander expression and should therefore be
-         * evaluated within a given context.
-         * <p> Use {@link #getTargetParameter(Map)} instead.</p>
-         */
-        @Deprecated
-        public List<String> getTargetParameterList() {
-            // Evaluate target-parameter with a null context, treating it as a 
plain string.
-            return getTargetParameterList(null);
-        }
-
         /**
          * Gets target parameter list.
          * @param context the context
diff --git 
a/framework/widget/src/test/java/org/apache/ofbiz/widget/model/ModelFormFieldTest.java
 
b/framework/widget/src/test/java/org/apache/ofbiz/widget/model/ModelFormFieldTest.java
index a3a50189c9..bbda231d5e 100644
--- 
a/framework/widget/src/test/java/org/apache/ofbiz/widget/model/ModelFormFieldTest.java
+++ 
b/framework/widget/src/test/java/org/apache/ofbiz/widget/model/ModelFormFieldTest.java
@@ -111,25 +111,6 @@ public final class ModelFormFieldTest {
         assertThat(field.getCurrentContainerId(ImmutableMap.of("prefix", 
"P2")), equalTo("P2IdValue"));
     }
 
-    /**
-     * Ensures behaviour of deprecated method 
LookupField#getTargetParameterList is maintained while the underlying
-     * property type is changed from String to FlexibleStringExpander.
-     */
-    @Test
-    @SuppressWarnings("deprecation")
-    public void lookupFieldDeprecatedMethodTreatsTargetParameterAsString() {
-        Element element = Mockito.mock(Element.class);
-        when(element.getTagName()).thenReturn("lookup");
-        when(element.getAttribute("maxlength")).thenReturn("1");
-        when(element.getAttribute("size")).thenReturn("1");
-        
when(element.getAttribute("target-parameter")).thenReturn("${prefix}TargetParam,
 ${key1}");
-
-        ModelFormField field = from(b -> b.setName("lookup-field"));
-        ModelFormField.LookupField lookupField = new 
ModelFormField.LookupField(element, field);
-
-        assertThat(lookupField.getTargetParameterList(), 
Matchers.contains("${prefix}TargetParam", "${key1}"));
-    }
-
     @Test
     public void lookupFieldUsesFlexibleTargetParameters() {
         Element element = Mockito.mock(Element.class);