[ofbiz-framework] branch trunk updated: Improved: Handle remaining checkstyle errors (OFBIZ-12169)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new a30d514  Improved: Handle remaining checkstyle errors (OFBIZ-12169)
a30d514 is described below

commit a30d514899e23d086cbe7c1ddac199b93770b786
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Sun Oct 17 11:43:48 2021 +0200

    Improved: Handle remaining checkstyle errors (OFBIZ-12169)
    
    Fixes wrong methods names in EntityFunction class
    Not sure why this one was missing (I used Eclipse refactoring and 
compilation
    worked locally)
---
 .../org/apache/ofbiz/accounting/thirdparty/paypal/PayPalServices.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/paypal/PayPalServices.java
 
b/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/paypal/PayPalServices.java
index 6a20533..3c1888f 100644
--- 
a/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/paypal/PayPalServices.java
+++ 
b/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/paypal/PayPalServices.java
@@ -447,7 +447,7 @@ public class PayPalServices {
         if (!newParty) {
             EntityCondition cond = 
EntityCondition.makeCondition(UtilMisc.toList(
                     EntityCondition.makeCondition(UtilMisc.toMap("partyId", 
partyId, "contactMechTypeId", "EMAIL_ADDRESS")),
-                    
EntityCondition.makeCondition(EntityFunction.UPPER_FIELD("infoString"), 
EntityComparisonOperator.EQUALS, EntityFunction.UPPER(emailAddress))));
+                    
EntityCondition.makeCondition(EntityFunction.upperField("infoString"), 
EntityComparisonOperator.EQUALS, EntityFunction.upper(emailAddress))));
             try {
                 GenericValue matchingEmail = 
EntityQuery.use(delegator).from("PartyAndContactMech").where(cond).orderBy("fromDate").filterByDate().queryFirst();
                 if (matchingEmail != null) {